Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any option to get scc 3.0.0 with 'go get' ? #270

Closed
gasuketsu opened this issue Jun 23, 2021 · 12 comments
Closed

Any option to get scc 3.0.0 with 'go get' ? #270

gasuketsu opened this issue Jun 23, 2021 · 12 comments
Labels
bug Something isn't working

Comments

@gasuketsu
Copy link

gasuketsu commented Jun 23, 2021

Current latest version of SCC is 3.0.0 but go get -u github.com/boyter/scc installs v2.12.0 and I could not get latest version.
is there any option to install latest release with go get ?

@gasuketsu gasuketsu changed the title Any option to scc 3.0.0 with 'go get' Any option to get scc 3.0.0 with 'go get' ? Jun 23, 2021
@boyter
Copy link
Owner

boyter commented Jun 24, 2021

Ah... I believe this is an issue with how im doing the releases currently. Ill have to look into fixing that... one of those Annoying things that happened with the go mod shift that I don't quite know how to resolve. Ill do some research and fix it.

@boyter boyter added the bug Something isn't working label Jun 24, 2021
@theKAKAN
Copy link

theKAKAN commented Sep 4, 2021

Current latest version of SCC is 3.0.0 but go get -u github.com/boyter/scc installs v2.12.0 and I could not get latest version.
is there any option to install latest release with go get ?

Hello, until this problem is resolved, one way to go get is to do it this way

go get -u github.com/boyter/scc/v3@master

@boyter
Copy link
Owner

boyter commented Sep 6, 2021

I really should find out how to fix this. One of those things that I keep neglecting. If someone has a good link to point at ill have a go.

@theKAKAN
Copy link

theKAKAN commented Sep 6, 2021

I really should find out how to fix this. One of those things that I keep neglecting. If someone has a good link to point at ill have a go.

direnv/direnv#629

They discuss it in pretty detail with other options you can opt for, it seems!

@boyter
Copy link
Owner

boyter commented Sep 6, 2021

Noice. Much appreciated.

@thomasf
Copy link

thomasf commented Sep 16, 2021

I think that just tagging a new v3 version should work now since you have added /v3 in go.mod

go install github.com/boyter/scc@latest installs version 2.12.0

trying to install v3.0.0 explicitly gives this error:

$ go install github.com/boyter/scc@v3.0.0
go install: github.com/boyter/scc@v3.0.0: github.com/boyter/scc@v3.0.0: invalid version: module contains a go.mod file, so major version must be compatible: should be v0 or v1, not v3

@thomasf
Copy link

thomasf commented Sep 19, 2021

So I guess that aaba4e5 resolved the issue but there hasn't been a tagged v3 release since before that change so it is still a practical problem.

@thomasf
Copy link

thomasf commented Sep 19, 2021

If you just want a working v3 you should probably just cherry pick that commit into v3.0.0 and relaease it as v3.0.1.
Right now go install github.com/boyter/scc installs a version (2.12) that just panics due to some .gitignore parsing package or something on almost every repositories I work on.

@boyter
Copy link
Owner

boyter commented Sep 19, 2021

@thomasf that annoying gitignore issue... One of the things I have in the next release is to build a proper .gitignore parser in as the current one has some edge case bugs. Ill have a look at this now.

@doomguy
Copy link

doomguy commented Jan 4, 2022

Also running into this right now :D
Btw. I think the preferred way to install execs is nowadays install instead of get:

go install github.com/boyter/scc@latest

or in this case

go install github.com/boyter/scc@master

@boyter
Copy link
Owner

boyter commented Jan 4, 2022

Updating documentation now.

Go releases is something I am woefully ignorant about since I tend to work with pure CI/CD release to production generally. I will be using GoReleaser for the next release to hopefully resolve this.

@boyter
Copy link
Owner

boyter commented Sep 29, 2022

This should be resolved now since using goreleaser.

@boyter boyter closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants