Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~[Installing] go get install deprecation #651

Closed
wants to merge 1 commit into from

Conversation

Rom1deTroyes
Copy link

Deprecation of 'go get' for installing executables

@see https://go.dev/doc/go-get-install-deprecation and golang/go#40276

close #649

An other TODO will be to make the deprecation in the CICD and Makefile :

But I got no time to make tests around today...
... Let's me know if you want me to do this simple change or if your preference goes to keep the CI/CD well maintained by yourself 🤔

@Rom1deTroyes
Copy link
Author

The pagination is awful (made it directly from GitHub for a quick fix...) : I can redo this less poorly later if needed ☹

Copy link

@llbbl llbbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be closed. #667 did a bit better job of explaining it. ✊🏼

chrisallenlane added a commit to chrisallenlane/cheat that referenced this pull request Jul 5, 2022
Use `go install` instead of `go get` now that the behavior of the latter
has changed.

See: cheat#651
chrisallenlane added a commit to chrisallenlane/cheat that referenced this pull request Jul 5, 2022
Use `go install` instead of `go get` now that the behavior of the latter
has changed.

See: cheat#651
chrisallenlane added a commit to chrisallenlane/cheat that referenced this pull request Jul 5, 2022
Use `go install` instead of `go get` now that the behavior of the latter
has changed.

See: cheat#651
@chrisallenlane
Copy link
Member

@Rom1deTroyes

Thanks very much for your PR, and for your other comments regarding go install.

I ended up overhauling the documentation surrounding installation, and created an INSTALLING.md file:
https://github.com/cheat/cheat/blob/master/INSTALLING.md

As such, I'll close this PR without merging, but thanks for your time in putting it together.

Regarding your other remarks regarding go install.

That was a really good catch. I tried to make the proposed go install changes in the CI configuration and Makefile, but interestingly, it failed because other dependencies would fail to install. As best as I can tell, the root cause of the problem is that I'm not the only Go author that was caught unaware of the go install/module behavior changes:

boyter/scc#270

That being the case, I'll continue to use go get -u for installing external packages, because it works even though it's incorrect. Once this gets sorted out upstream, I'll make the corresponding changes to this project as well.

Thanks again for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants