-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV format is broken #332
Comments
Another issue: it outputs one extra empty line at the end. |
Thats odd... I was using the standard library CSV stuff in Go which I would have thought would solve this. |
I checked this right now on the Free Code camp repository and my testing one, and the quoting seems to work properly:
|
Neat perhaps that's the trick then. When I get some time ill have another look at this. Unless someone wants to solve it before then :) |
Not fixed. For example, see https://github.com/anthraxx/linux-hardened/tree/master/drivers/staging/mt7621-pci And the
The invocation is as follows: |
I looked into the code and |
Yep. I am still working on getting the walking to respect all ignore files properly first, once thats done I can come along and clean up a lot of these issues. |
With the latest release 3.3.3 this is included now so closing down. |
Describe the bug
If filename contains
,
character, it is not properly quoted in CSV.To Reproduce
Clone this repo and run scc: https://github.com/freeCodeCamp/freeCodeCamp
The offending file name is
curriculum/challenges/italian/08-data-analysis-with-python/numpy/accessing-and-changing-elements,-rows,-columns.md
.Expected behavior
Put filename in quotes (
"filename"
) if needed. The quote"
characters should be also escaped as""
,example: if filename is
Hello, "world"
, it should be output as"Hello, ""world"""
.Also take care for newlines, tabs and everything else in filenames.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: