Enable checkaction=context in dub

[Geod24]

This will fail with < 2.087.1

[Geod24]

This is blocked by a bunch of upstream fixes

[Geod24]

Would be great to get someone to look into this one at some point.

[Geod24]

This still has issues...

/usr/lib/gcc/x86_64-alpine-linux-musl/9.2.0/../../../../x86_64-alpine-linux-musl/bin/ld.bfd: /tmp/.rdmd-0/rdmd-build.d-E96E07B52D5C24B890B67CA5F414DDBA/objs/build.o: in function `_D4core8internal7dassert__T14_d_assert_failVAyaa1_3cTmTmZQBeFNaNbNiNfxmxmZQBe':
attributes.d:(.text._D4core8internal7dassert__T14_d_assert_failVAyaa1_3cTmTmZQBeFNaNbNiNfxmxmZQBe[_D4core8internal7dassert__T14_d_assert_failVAyaa1_3cTmTmZQBeFNaNbNiNfxmxmZQBe]+0x20): undefined reference to `_D4core8internal7dassert__T24miniFormatFakeAttributesTmZQBdFNaNbNiNfKxmZAya'
/usr/lib/gcc/x86_64-alpine-linux-musl/9.2.0/../../../../x86_64-alpine-linux-musl/bin/ld.bfd: attributes.d:(.text._D4core8internal7dassert__T14_d_assert_failVAyaa1_3cTmTmZQBeFNaNbNiNfxmxmZQBe[_D4core8internal7dassert__T14_d_assert_failVAyaa1_3cTmTmZQBeFNaNbNiNfxmxmZQBe]+0x31): undefined reference to `_D4core8internal7dassert__T24miniFormatFakeAttributesTmZQBdFNaNbNiNfKxmZAya'
/usr/lib/gcc/x86_64-alpine-linux-musl/9.2.0/../../../../x86_64-alpine-linux-musl/bin/ld.bfd: /tmp/.rdmd-0/rdmd-build.d-E96E07B52D5C24B890B67CA5F414DDBA/objs/build.o: in function `_D3std8typecons__T10RefCountedTSQBe4file15DirIteratorImplVEQCfQCe24RefCountedAutoInitializei0ZQCy6__dtorMFZv':
attributes.d:(.text._D3std8typecons__T10RefCountedTSQBe4file15DirIteratorImplVEQCfQCe24RefCountedAutoInitializei0ZQCy6__dtorMFZv[_D3std8typecons__T10RefCountedTSQBe4file15DirIteratorImplVEQCfQCe24RefCountedAutoInitializei0ZQCy6__dtorMFZv]+0xad): undefined reference to `_D4core8internal7dassert__T14_d_assert_failVAyaa1_3eTmTmZQBeFNaNbNiNfKxmxmZQBf'
collect2: error: ld returned 1 exit status
Error: /usr/bin/cc failed with status: 1

[Geod24]

https://issues.dlang.org/show_bug.cgi?id=19937

[Geod24]

So it passes with DMD but not with LDC. It might be because we're using bfd instead of gold ?
LDC calls it "buggy old linker" but I wonder if the bug is really in ld.bfd...

[codecov]

Codecov Report

Merging #142 into v0.x.x will decrease coverage by 2.45%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           v0.x.x     #142      +/-   ##
==========================================
- Coverage   91.11%   88.66%   -2.46%     
==========================================
  Files          63       59       -4     
  Lines        4786     4377     -409     
==========================================
- Hits         4361     3881     -480     
- Misses        425      496      +71

Flag	Coverage Δ
#integration	?
#unittests	88.66% <0%> (-1.21%)	⬇️

Impacted Files	Coverage Δ
source/agora/utils/Workarounds.d	0% <0%> (ø)
source/agora/common/Task.d	0% <0%> (-100%)	⬇️
source/agora/common/Config.d	74.64% <0%> (-16.2%)	⬇️
source/scpd/types/XDRBase.d	27.27% <0%> (-11.19%)	⬇️
source/agora/network/NetworkManager.d	69.86% <0%> (-9.76%)	⬇️
source/agora/node/Node.d	90.36% <0%> (-9.64%)	⬇️
source/agora/consensus/EnrollmentManager.d	86.62% <0%> (-6.45%)	⬇️
source/agora/common/crypto/Key.d	84.25% <0%> (-5.13%)	⬇️
source/agora/common/BitField.d	94.23% <0%> (-2.96%)	⬇️
source/agora/node/BlockStorage.d	67.87% <0%> (-2.51%)	⬇️
... and 46 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e09d0...16d999b. Read the comment docs.

[Geod24]

So we dropped DMD. And I've seen Kinke actively working on this. We might get lucky and get it to work in either LDC 1.21.0 (if we're really lucky), or LDC 1.22.0. Let's stay tuned for the LDC beta for once.

[AndrejMitrovic]

Can close this now? Or was the plan enabling it for non-unittest builds too?

[Geod24]

Or was the plan enabling it for non-unittest builds too?

Not ready to open this can of worm just yet.

Can close this now?

Indeed, done in #2038 . It only took 1896 PRs / issues and a bit less than 2 years.