Always validate diagram (in background) #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
a team,
marstamm and
barmac
and removed request for
a team
bpmn-io-tasks
bot
added
in progress
nikku
force-pushed
the
info-type
branch
2 times, most recently
from
1dba86e
to
e6fa5b4
Compare
bpmn-io-tasks
bot
added
needs review
|
I cannot look into this this week, so feel free to assign another reviewer. |
nikku
force-pushed
the
eagerly-validate
branch
2 times, most recently
from
c818cba
to
904b477
Compare
Always validate, indicate results in overlay. Toggle overlays on button click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the plug-in to eagerly validate a diagram. The button we previously used to toggle linting now acts as a toggle for showing annotations on the canvas.
Closes #20