Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Copying Boundary Events #1154

Closed
philippfromme opened this issue Aug 8, 2019 · 4 comments · Fixed by #1192 or #1203
Closed

Allow Copying Boundary Events #1154

philippfromme opened this issue Aug 8, 2019 · 4 comments · Fixed by #1192 or #1203
Assignees
@oguzeroglu
Labels
enhancement New feature or request good first issue Good for newcomers modeling
Milestone
M31

Comments

@philippfromme
Copy link
Contributor

Since detaching of boundary events is now possible it should be possible to copy boundary events. This is only prevented by the element.copy rule.

When disabling this rule:

foobar
@nikku
Copy link
Member

nikku commented Aug 8, 2019

Works? 🐙

@nikku nikku added enhancement New feature or request good first issue Good for newcomers backlog Queued in backlog modeling labels Aug 8, 2019
@nikku
Copy link
Member

nikku commented Aug 8, 2019

Makes a lot of sense, thanks for reporting 👍

@philippfromme
Copy link
Contributor Author

Works? 🐙

Yeah, it works.

@nikku nikku added this to the M31 milestone Sep 9, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Sep 9, 2019
@oguzeroglu oguzeroglu self-assigned this Sep 11, 2019
@oguzeroglu oguzeroglu added in progress Currently worked on and removed ready Ready to be worked on labels Sep 11, 2019 — with bpmn-io-tasks
@oguzeroglu
Copy link
Contributor

oguzeroglu commented Sep 11, 2019 •
edited

Realised this behaviour while working on this issue.

oguzeroglu pushed a commit that referenced this issue Sep 20, 2019
feat(features): copy non attached boundary events as well
40f8929 
Closes #1154
@oguzeroglu oguzeroglu mentioned this issue Sep 20, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 20, 2019
oguzeroglu pushed a commit that referenced this issue Sep 20, 2019
feat(copy-paste): copy non attached boundary events as well
cef6b9c 
Closes #1154
oguzeroglu pushed a commit that referenced this issue Sep 20, 2019
feat(copy-paste): copy non attached boundary events as well
fc1f0b9 
Closes #1154
oguzeroglu pushed a commit that referenced this issue Sep 23, 2019
feat(copy-paste): copy non attached boundary events as well
12df568 
Closes #1154
oguzeroglu pushed a commit that referenced this issue Sep 24, 2019
feat(copy-paste): copy non attached boundary events as well
b242972 
Closes #1154
oguzeroglu pushed a commit that referenced this issue Sep 25, 2019
feat(copy-paste): copy non attached boundary events as well
05b27cc 
Closes #1154
oguzeroglu pushed a commit that referenced this issue Sep 25, 2019
feat(copy-paste): copy non attached boundary events as well
09db38e 
Closes #1154
@fake-join fake-join bot closed this as completed in #1192 Sep 25, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 25, 2019
fake-join bot pushed a commit that referenced this issue Sep 25, 2019
@fake-join
feat(copy-paste): copy non attached boundary events as well
8aa4095 
Closes #1154
@bpmn-io-tasks bpmn-io-tasks bot reopened this Sep 26, 2019
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 26, 2019
oguzeroglu pushed a commit that referenced this issue Sep 26, 2019
feat(copy-paste): copy non attached boundary events as well
c5ca086 
Closes #1154
@oguzeroglu oguzeroglu mentioned this issue Sep 26, 2019
Merged
philippfromme pushed a commit to bpmn-io/diagram-js that referenced this issue Sep 26, 2019
@philippfromme
feat(copy-paste): be able to specify hints
09d13e9 
Related to bpmn-io/bpmn-js#1154
oguzeroglu pushed a commit that referenced this issue Sep 27, 2019
feat(copy-paste): copy non attached boundary events as well
ff6303c 
Closes #1154
philippfromme added a commit that referenced this issue Oct 4, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
455c882 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
oguzeroglu pushed a commit that referenced this issue Oct 7, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
9da6f27 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
oguzeroglu pushed a commit that referenced this issue Oct 7, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
c015425 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
oguzeroglu pushed a commit that referenced this issue Oct 7, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
5324e73 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
oguzeroglu pushed a commit that referenced this issue Oct 7, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
bf7c85d 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
philippfromme added a commit that referenced this issue Oct 10, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
853799b 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Oct 10, 2019 — with bpmn-io-tasks
philippfromme added a commit that referenced this issue Oct 10, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
57ab5b3 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
philippfromme added a commit that referenced this issue Oct 10, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
1cc9675 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
barmac pushed a commit that referenced this issue Oct 11, 2019
@philippfromme @barmac
feat(copy-paste): copy and paste boundary events
94e2e44 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
philippfromme added a commit that referenced this issue Oct 11, 2019
@philippfromme
feat(copy-paste): copy and paste boundary events
e85fc66 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
philippfromme added a commit that referenced this issue Oct 13, 2019
@philippfromme
fix(modeling): copy and paste boundary events
6baa0dd 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
Closes #1202
Closes #1204
Closes #1205
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 13, 2019
philippfromme added a commit that referenced this issue Oct 13, 2019
@philippfromme
fix(modeling): copy and paste boundary events
1878379 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
Closes #1202
Closes #1204
Closes #1205
philippfromme added a commit that referenced this issue Oct 13, 2019
@philippfromme
feat(modeling): copy and paste boundary events
2e27d74 
* allow copying boundary events without host
* remove CreateBoundaryEventBehavior in favor of AttachEventBehavior

Closes #1154
Closes #1202
Closes #1204
Closes #1205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oguzeroglu oguzeroglu

Labels
enhancement New feature or request good first issue Good for newcomers modeling
Milestone
M31
3 participants
@nikku @philippfromme @oguzeroglu