Boundary Events not detached when moved out of host in a batch move

[barmac]

Describe the Bug

The Boundary Events are not converted to Intermediate Events when moved to canvas in a batch operation.

Steps to Reproduce

1. Select multiple Boundary Events
2. Move them to canvas.

Expected Behavior

Such operation should either be disallowed or the events should be converted to Intermediate Events.

Environment

• Browser: Chrome
• OS: MacOS
• Library version: 5.0.4

[oguzeroglu]

This line causes the problem, since the array length is more than 1 in this case DetachEventBehavior just does an early return instead of replacing elements.

[oguzeroglu]

Replacing elements.move preExecute in DetachEventBehaviour fixes the problem:

  this.preExecute('elements.move', function(context) {
    var shapes = context.shapes;

    shapes.filter(function(shape) {
      var hasHost = (shape.host && (context.shapes.indexOf(shape.host) > -1)) ? true : !!context.newHost;
      return shouldReplace(shape, hasHost);
    }).map(function(shape) {
      return shapes.indexOf(shape);
    }).forEach(function(index) {
      shapes[ index ] = replaceShape(shapes[ index ], bpmnReplace);
    });
  }, true);

This is the tricky part:

var hasHost = (shape.host && (context.shapes.indexOf(shape.host) > -1)) ? true : !!context.newHost;

For edge cases where a boundary event is attached to a task and we move them all together, context.newHost is null however the Detach behaviour in that case should not apply to the Boundary Event (since it is being carried with its host), therefore we check if a shape has a host and this host is inside the moved shapes within the context to decide if it has a host or not, for other cases checking if context.newHost exists is enough. Since this is preExecute shape.host refers to the host before the replace.

[oguzeroglu]

Closed via #1206

[philippfromme]

Will be properly fixed through #1203