Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-pasting collapsed subprocess does not past child elements correctly #1270

Closed
yT0n1 opened this issue Jan 24, 2020 · 3 comments
Closed
Labels
bug Something isn't working pr welcome We rely on a community contribution to improve this.

Comments

@yT0n1
Copy link

yT0n1 commented Jan 24, 2020

Copying and pasting collapsed subprocess does not paste task inside subprocess

When copy-pasting a collapsed subprocess that contains a task, the task is pasted on top of the collapsed subprocess. However, this appears to be just a visual problem. When downloading and reimporting the .bpmn file everything is fine.

BrokenCopy

Steps to Reproduce

  1. Create expanded subprocess and add at least one child task
  2. Collapse the subprocess
  3. Copy the sub process
  4. Paste the sub process.

Expected Behavior

The child task should be visually hidden.

Environment

  • Browser: [e.g. Firefox Developer Edition]
  • OS: [ Mac OS X ]
  • Library version: [v6.2.0]
@yT0n1 yT0n1 added the bug Something isn't working label Jan 24, 2020
@yT0n1
Copy link
Author

yT0n1 commented Jan 24, 2020

As far as I can see, the problem appears to be that the shape.hidden property is not copied.

@nikku
Copy link
Member

nikku commented Jan 24, 2020

Thanks for your report and thanks for conducting further investigation.

The place in the source code where this one is missing is probably CopyPaste in diagram-js.

Would you like to contribute a PR? If that is the case we'd need a fix + an accompanying test case (cf. CopyPasteSpec).

@nikku nikku added backlog Queued in backlog pr welcome We rely on a community contribution to improve this. labels Jan 24, 2020
@yT0n1
Copy link
Author

yT0n1 commented Jan 24, 2020

I will give it a try.

@nikku nikku added fixed upstream Requires integration of upstream change and removed backlog Queued in backlog labels Feb 7, 2020 — with bpmn-io-tasks
@nikku nikku closed this as completed in 5844ede Feb 7, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pr welcome We rely on a community contribution to improve this.
Projects
None yet
Development

No branches or pull requests

2 participants