Prevent expanded subprocess overlap of previous content #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
gustavjf
force-pushed
the
adjust-expanded-subprocess-position-if-overlaps-previous-content
branch
4 times, most recently
from
2216a31
to
1597f18
Compare
gustavjf
changed the title
This covers two scenarios: 1. When a shape is replaced with an expanded subprocess 2. When a subprocess is toggled from collapsed to expanded Only when: 1. There are incoming sequence flows (previous content) 2. There are no outgoing sequence flows (following content)
philippfromme
force-pushed
the
adjust-expanded-subprocess-position-if-overlaps-previous-content
branch
from
1597f18
to
7d05ff1
Compare
philippfromme
approved these changes
May 15, 2019
delete-merged-branch
bot
deleted the
adjust-expanded-subprocess-position-if-overlaps-previous-content
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR address?
Relates to camunda/camunda-modeler#1244
Description
This covers two scenarios:
Only when:
Notes for reviewer
The connection layout breaks when replacing/toggling, as shown in the screen captures above. This is a known issue.
The CI fails on codecoverage due to missing tests for this and this code path.
Since pools do not trigger
toggleCollapseevents and we may decide to add support for other elements which can be collapsed in the future (i.e., collapsed sub-choreographies), I think it makes sense to ignore codecov and keep those conditions in the code. As far as I'm aware, we don't have other elements which can be collapsed viatoggleCollapseexcept for subprocesses so trying to write a test for this may not make sense.