-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sub Process moves position #1418
Comments
Related to bpmn-io/bpmn-js#1026, bpmn-io/bpmn-js#1052 |
Could also be related to bpmn-io/bpmn-js#1103 |
Root Cause Regarding the vertical movement: The misalignment comes from an offset generated by Cf. However, this does not also cause the horizontal movement when transforming the task to a subprocess. Further investigation needed. |
Regarding the horizontal movement of the SubProcess: The movement resolves in newly calculated optimal bounds which takes the automatically created start event into account. That's why the start Event seems to be moved inside the SubProcess after re-expanding (as the screencast above reveals). This behavior is also shown in previous version The behavior described above with empty subProcesses only comes from the fact we're automatically creating a new startEvent when morphing a task to an expanded subProcess. This relates to bpmn-io/bpmn-js#1031 So this is not a regression . It is caused by the fact when calculating the new bounds in To fix this, we will have to somehow save the bounds from the expanded subProcess. For example via Extension Element. |
After a discussion with @volkergersabeck we concluded to postpone this when we tackle an overall improvement-run regarding Modeling with SubProcesses in the next quarter. This will include several improvements like this one or #1244, #1343. Roo-Cause-Analysis is described in following commits
|
Closing this as we do not allow to collapse sub-processes anymore. |
Describe the Bug
Sub Process moves position after expand & collapse operation
Steps to Reproduce
// given
element chain of star event --> task --> end event
// when
I perform the follwong operations:
// then
the position of the sub process has moved and is not aligned with the other elements anymore
Expected Behavior
sub process keeps position
Environment
Please complete the following information:
The text was updated successfully, but these errors were encountered: