Skip to content

Commit

Permalink
fix(popup-menu): improve set off from background
Browse files Browse the repository at this point in the history
  • Loading branch information
nikku authored and barmac committed Jan 27, 2023
1 parent 6125c80 commit 31b662d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions assets/diagram-js.css
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
--color-white: hsl(0, 0%, 100%);
--color-black: hsl(0, 0%, 0%);
--color-black-opacity-10: hsla(0, 0%, 0%, 10%);
--color-black-opacity-30: hsla(0, 0%, 0%, 30%);

--canvas-fill-color: var(--color-white);

Expand Down Expand Up @@ -58,8 +59,8 @@
--popup-header-entry-selected-color: var(--color-blue-205-100-50);
--popup-header-font-weight: bolder;
--popup-background-color: var(--color-white);
--popup-border-color: var(--color-grey-225-10-75);
--popup-shadow-color: var(--color-grey-225-10-80);
--popup-border-color: transparent;
--popup-shadow-color: var(--color-black-opacity-30);
--popup-description-color: var(--color-grey-225-10-55);
--popup-no-results-color: var(--color-grey-225-10-55);
--popup-entry-title-color: var(--color-grey-225-10-55);
Expand Down Expand Up @@ -527,12 +528,14 @@ marker.djs-dragger tspan {
}

.djs-popup {
box-sizing: border-box;
width: min-content;
background: var(--popup-background-color);
overflow: hidden;
position: absolute;

box-shadow: 0px 2px 10px var(--popup-shadow-color);
box-shadow: 0px 2px 6px var(--popup-shadow-color);
border: solid 1px var(--popup-border-color);
min-width: 120px;
outline: none;
font-size: var(--popup-font-size);
Expand Down
2 changes: 1 addition & 1 deletion test/spec/features/popup-menu/PopupMenuSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1488,7 +1488,7 @@ describe('features/popup-menu', function() {
};

// then
expect(menu.offsetTop).to.be.closeTo(y - menuDimensions.height, 1);
expect(menu.offsetTop).to.be.closeTo(y - menuDimensions.height, 3);
}));


Expand Down

0 comments on commit 31b662d

Please sign in to comment.