Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the visibility of the popup menu #1812

Closed
rpkoller opened this issue Jan 16, 2023 · 6 comments
Closed

Improve the visibility of the popup menu #1812

rpkoller opened this issue Jan 16, 2023 · 6 comments
Assignees
Labels
a11y enhancement New feature or request good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day

Comments

@rpkoller
Copy link

Is your feature request related to a problem? Please describe
that is a bit of a controversial issue. it is basically in reference to WCAG2.1 SC 1.4.11 which is usually interpreted in the context of single ui components like buttons and alike. but if you have a model and open up the element template chooser it is quite challenging to find and focus on the modal. One example in Camunda:

Screen Shot 2023-01-16 at 17 47 27

and one example in ECA in Drupal:

Screen Shot 2023-01-16 at 17 48 09

in Camunda:
0px 2px 10px var(--change-menu-shadow-color)the value of the variable is hsla(0, 0%, 0%, 25%); which leads to:
https://contrast-ratio.com/#hsla%280%2C%200%25%2C%200%25%2C%2025%25%29-on-white
=> color contrast of 1.83:1 but 3:1 is needed.

in ECA:
0px 2px 10px var(--popup-shadow-color) the value of the variable is hsl(225, 10%, 80%); which leads to:
https://contrast-ratio.com/#hsl%28225%2C%2010%25%2C%2080%25%29-on-white
=> color contrast of 1.65:1 but 3:1 is needed.

Describe the solution you'd like
Ideally the element template chooser modal should stand out more clearly so it is easier to distinguish what is the model and what is a widget/modal.
strictly speaking that issue applies to the toolbar and the properties panel to a certain degree as well. but due to the fact that the element template chooser has a white background color same like the background of the canvas and it is only separated by the box shadow makes it more of an issue for the element template chooser.

Describe alternatives you've considered

Additional context

@rpkoller rpkoller added the enhancement New feature or request label Jan 16, 2023
@nikku
Copy link
Member

nikku commented Jan 23, 2023

A simple way to improve the visual apperance could be to provide a dedicated border:

capture cRT8lP_optimized

CC @YanaSegal Maybe way we can fine-tune this?

@nikku nikku transferred this issue from bpmn-io/element-template-chooser Jan 23, 2023
@nikku nikku added a11y modeling good first issue Good for newcomers backlog Queued in backlog spring cleaning Could be cleaned up one day labels Jan 23, 2023
@nikku
Copy link
Member

nikku commented Jan 23, 2023

Moved over to bpmn-js as we have the same issue in core modeling (and the chooser component depends on that).

@nikku nikku removed the backlog Queued in backlog label Jan 23, 2023
@nikku nikku changed the title Improve the visibility of the element template chooser Improve the visibility of the popup menu Jan 24, 2023
@barmac barmac added the backlog Queued in backlog label Jan 24, 2023
@barmac
Copy link
Member

barmac commented Jan 24, 2023

To be honest, I like the bordered version more.

@nikku
Copy link
Member

nikku commented Jan 24, 2023

We decided to go for option 3️⃣ Align with Carbon Design for the basics and slightly improve shadow.

@nikku
Copy link
Member

nikku commented Jan 24, 2023

@rpkoller via bpmn-io/diagram-js#743 we'll improve the background shadow to better set off the element.

In addition you may customize the popup menu border through the --popup-menu-border CSS variable.

nikku added a commit to bpmn-io/diagram-js that referenced this issue Jan 24, 2023
barmac pushed a commit to bpmn-io/diagram-js that referenced this issue Jan 27, 2023
nikku added a commit to bpmn-io/diagram-js that referenced this issue Feb 2, 2023
@nikku
Copy link
Member

nikku commented Feb 6, 2023

Closed with 496c6f6.

@nikku nikku closed this as completed Feb 6, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Feb 6, 2023
@nikku nikku self-assigned this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y enhancement New feature or request good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day
Development

No branches or pull requests

3 participants