Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap During Resize #344

Merged
merged 5 commits into from
Jun 5, 2019
Merged

Snap During Resize #344

merged 5 commits into from
Jun 5, 2019

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented May 23, 2019

  • allow constraining create (required by bpmn-io/bpmn-js@5c83fbf)
  • prevent move/resize if unnecessary
  • snap to borders on create/move
  • add resize snapping
  • separate create/move snapping integration from core snapping

Required by bpmn-io/bpmn-js#1046.
Related to camunda/camunda-modeler#1290.

@philippfromme philippfromme force-pushed the 1290-snap-on-resize branch 3 times, most recently from 0c52e40 to be8d806 Compare May 23, 2019 20:47
@philippfromme philippfromme changed the title WIP Snap During Resize Snap During Resize May 23, 2019
@philippfromme philippfromme requested a review from nikku May 23, 2019 21:06
@nikku nikku added the needs review Review pending label May 31, 2019 — with bpmn-io-tasks
@merge-me merge-me bot merged commit cc6b73a into master Jun 5, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1290-snap-on-resize branch June 5, 2019 12:33
@nikku
Copy link
Member

nikku commented Jun 5, 2019

One thing we could consider in the future is to extract the constraint logic we have in resize and create into its own component (if both concepts are similar enough).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants