Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce snap on resize #1290

Closed
1 task done
nikku opened this issue Mar 6, 2019 · 1 comment · Fixed by #1404
Closed
1 task done

Introduce snap on resize #1290

nikku opened this issue Mar 6, 2019 · 1 comment · Fixed by #1404
Assignees
@philippfromme
Labels
enhancement New feature or request modeling
Milestone
M29

Comments

@nikku
Copy link
Member

nikku commented Mar 6, 2019 •
edited by philippfromme
Loading

Is your feature request related to a problem? Please describe.

For esthetic and readability reasons it I'd like to make sure that my diagram is nicely organized. This includes that participants and text annotations that are related have the same size.

foo

This does not only apply to participants but to sub processes and text annotations, too.

Describe the solution you'd like

  • Snap on resize to similar corners of neighboring elements

Describe alternatives you've considered

We could ditch this and rely on snap to grid #1019 for the work. This, however, assumes that snap to grid is available (and all existing diagrams are snapped).

Additional context

This should fix #609
This should fix #608
@nikku nikku added modeling enhancement New feature or request labels Mar 6, 2019
@nikku nikku added this to the M29 milestone Mar 6, 2019
This was referenced Mar 6, 2019
Closed
Closed
@philippfromme philippfromme self-assigned this Apr 1, 2019
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Apr 2, 2019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue May 13, 2019
@philippfromme
feat(create): allow constraints
9b57736 
Related to camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue May 20, 2019
@philippfromme
feat(create): allow constraints
1f3b41c 
Related to camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue May 23, 2019
@philippfromme
feat(create): allow constraints
3d1203f 
Related to camunda/camunda-modeler#1290
@philippfromme philippfromme mentioned this issue May 23, 2019
Merged
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue May 23, 2019
@philippfromme
feat(create): allow constraints
56ba3e6 
Related to camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 23, 2019
@philippfromme
chore(bpmn-snapping): seperate snapping into create/move and connect
94310f7 
* move create/move snapping to BpmnCreateMoveSnapping
* move connect snapping to BpmnConnectSnapping
* refactor tests

Related camunda/camunda-modeler#1290
@philippfromme philippfromme mentioned this issue May 23, 2019
Merged
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 29, 2019
@philippfromme
chore(bpmn-snapping): seperate snapping into create/move and connect
6bbd725 
* move create/move snapping to BpmnCreateMoveSnapping
* move connect snapping to BpmnConnectSnapping
* refactor tests

Related camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue May 29, 2019
@philippfromme
chore(bpmn-snapping): seperate snapping into create/move and connect
84dbeb3 
* move create/move snapping to BpmnCreateMoveSnapping
* move connect snapping to BpmnConnectSnapping
* refactor tests

Related camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue May 29, 2019
@philippfromme
feat(create): allow constraints
5cb4c05 
Related to camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Jun 3, 2019
@philippfromme
chore(bpmn-snapping): seperate snapping into create/move and connect
f9e5ed3 
* move create/move snapping to BpmnCreateMoveSnapping
* move connect snapping to BpmnConnectSnapping
* refactor tests

Related camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Jun 3, 2019
@philippfromme
chore(bpmn-snapping): seperate snapping into create/move and connect
b1a4a42 
* move create/move snapping to BpmnCreateMoveSnapping
* move connect snapping to BpmnConnectSnapping
* refactor tests

Related camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jun 5, 2019
@philippfromme
feat(create): allow constraints
e196e15 
Related to camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Jun 5, 2019
@philippfromme
feat(create): allow constraints
5cdebac 
Related to camunda/camunda-modeler#1290
philippfromme added a commit to bpmn-io/bpmn-js that referenced this issue Jun 5, 2019
@philippfromme
chore(bpmn-snapping): seperate snapping into create/move and connect
54598bf 
* move create/move snapping to BpmnCreateMoveSnapping
* move connect snapping to BpmnConnectSnapping
* refactor tests

Related camunda/camunda-modeler#1290
merge-me bot pushed a commit to bpmn-io/diagram-js that referenced this issue Jun 5, 2019
@philippfromme @merge-me
feat(create): allow constraints
d8f7dbc 
Related to camunda/camunda-modeler#1290
@nikku nikku added the fixed upstream Requires integration of upstream change label Jun 5, 2019
nikku pushed a commit to bpmn-io/bpmn-js that referenced this issue Jun 5, 2019
@philippfromme @nikku
chore(bpmn-snapping): seperate snapping into create/move and connect
a98c8e3 
* move create/move snapping to BpmnCreateMoveSnapping
* move connect snapping to BpmnConnectSnapping
* refactor tests

Related camunda/camunda-modeler#1290
nikku added a commit that referenced this issue Jun 13, 2019
@nikku
feat(client): bump to bpmn-js@4.0.0-beta.1
bc7513d 
Closes #1242
Closes #903
Closes #637
Closes #1290
Closes #609
Closes #608
Closes #1206
Closes #464
Closes #1019
Closes #239
@nikku nikku mentioned this issue Jun 13, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Jun 13, 2019
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jun 13, 2019
@nikku
Copy link
Member Author

nikku commented Jun 13, 2019

Closed via #1404.

@nikku nikku closed this as completed Jun 13, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 13, 2019
@nikku nikku removed fixed upstream Requires integration of upstream change labels Jun 13, 2019
nedyalkonikolov pushed a commit to nedyalkonikolov/camunda-modeler that referenced this issue Jun 18, 2019
@nikku @merge-me
feat(client): bump to bpmn-js@4.0.0-beta.1
f272681 
Closes camunda#1242
Closes camunda#903
Closes camunda#637
Closes camunda#1290
Closes camunda#609
Closes camunda#608
Closes camunda#1206
Closes camunda#464
Closes camunda#1019
Closes camunda#239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
enhancement New feature or request modeling
Projects
None yet
Milestone
M29
Development

Successfully merging a pull request may close this issue.

feat(client): bump to bpmn-js@4.0.0-beta.1 camunda/camunda-modeler
2 participants
@nikku @philippfromme