fix(popup-menu): do not search by entry id #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smbea
commented
Dec 8, 2022
nikku
reviewed
Dec 8, 2022
nikku
reviewed
Dec 8, 2022
There was a problem hiding this comment.
Please consider a small improvement to the new test: https://github.com/bpmn-io/diagram-js/pull/720/files#r1043262244.
But other than that, great.
smbea
force-pushed
the
fix-popup-search
branch
from
092a4da
to
a83cd81
Compare
smbea
commented
Dec 8, 2022
smbea
force-pushed
the
fix-popup-search
branch
from
a83cd81
to
8d03192
Compare
nikku
approved these changes
Dec 8, 2022
|
Good stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#3347