Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Menu Search only triggers on second character #3347

Closed
Tracked by #1793
marstamm opened this issue Dec 8, 2022 · 3 comments · Fixed by #3351
Closed
Tracked by #1793

Replace Menu Search only triggers on second character #3347

marstamm opened this issue Dec 8, 2022 · 3 comments · Fixed by #3351
Assignees
Labels
bug Something isn't working
Milestone

Comments

@marstamm
Copy link
Member

marstamm commented Dec 8, 2022

Describe the bug

In Certain starting letters, the list of replace options is not filtered:

Recording 2022-12-08 at 09 36 32

Steps to reproduce

  1. open the replace menu on a task
  2. Type "R" in the filter
  3. Nothing happens

Expected behavior

Entries without "R" (like Manual Task) are hidden

Environment

Camunda Modeler system information

  • Version: 5.6.0-rc.0
  • Operating System: Linux x86_64 amd64
  • Plugins:
  • Execution Platform: BPMN - Camunda Platform 8

Additional context

No response

@marstamm marstamm added the bug Something isn't working label Dec 8, 2022
@marstamm
Copy link
Member Author

marstamm commented Dec 8, 2022

I can reproduce it back in bpmn-js. It seems like we filter for the entry ID instead of the label. I think this is a bit unexpected from the user perspektive

Recording 2022-12-08 at 09 42 47

@nikku
Copy link
Member

nikku commented Dec 8, 2022

👍 Should not filter by ID (unsurprising results).

@nikku nikku added this to the M60 milestone Dec 8, 2022
@nikku nikku added the ready Ready to be worked on label Dec 8, 2022
@smbea
Copy link
Contributor

smbea commented Dec 8, 2022

I'm looking into this. Should be simple enough to take the id out of the search criteria

smbea added a commit to bpmn-io/diagram-js that referenced this issue Dec 8, 2022
smbea added a commit to bpmn-io/diagram-js that referenced this issue Dec 8, 2022
smbea added a commit to bpmn-io/diagram-js that referenced this issue Dec 8, 2022
smbea added a commit to bpmn-io/diagram-js that referenced this issue Dec 8, 2022
nikku pushed a commit to bpmn-io/diagram-js that referenced this issue Dec 8, 2022
@smbea smbea added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Dec 8, 2022
barmac added a commit that referenced this issue Dec 8, 2022
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Dec 8, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change in progress Currently worked on labels Dec 8, 2022
nikku pushed a commit that referenced this issue Dec 8, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 8, 2022
@nikku nikku modified the milestones: M60, M59 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants