Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text adornment ellipsis #538

Merged
merged 2 commits into from
Feb 3, 2023
Merged

fix: text adornment ellipsis #538

merged 2 commits into from
Feb 3, 2023

Conversation

Skaiir
Copy link
Contributor

@Skaiir Skaiir commented Feb 3, 2023

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 3, 2023
@Skaiir
Copy link
Contributor Author

Skaiir commented Feb 3, 2023

Ellipsis doesn't work directly on flex elements, so I nested text within a span, also I disabled whitespace wrapping.

@pinussilvestrus pinussilvestrus changed the base branch from develop to master February 3, 2023 07:18
pinussilvestrus
pinussilvestrus approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@pinussilvestrus pinussilvestrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I added an a11y to the text field with adorners to ensure we have it covered. I also added a class name to the new span element, as it makes it easier to customize these elements.

@pinussilvestrus pinussilvestrus merged commit 46188e3 into master Feb 3, 2023
@pinussilvestrus pinussilvestrus deleted the fix-adornment-ellipsis branch February 3, 2023 08:37
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinussilvestrus pinussilvestrus pinussilvestrus approved these changes

@vsgoulart vsgoulart Awaiting requested review from vsgoulart

Assignees

@Skaiir Skaiir

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skaiir @pinussilvestrus