Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflowing long prefix and suffix values in the form fields #3381

Closed
GeethaParthasarathy opened this issue Jan 6, 2023 · 7 comments · Fixed by #3422
Closed

Overflowing long prefix and suffix values in the form fields #3381

GeethaParthasarathy opened this issue Jan 6, 2023 · 7 comments · Fixed by #3422
Assignees
Labels
bug Something isn't working Forms
Milestone

Comments

@GeethaParthasarathy
Copy link

Describe the bug

When we add a long prefix and suffix values to any form element we could see it overflowing from the sides

Steps to reproduce

  1. Create a new form
  2. Add any form element say Text field
  3. Add quite a long text for prefix and suffix
  4. We could see that the text is overflowing from the sides of the field

51e9d2df22a76416a4edefa3776bd327

Expected behavior

We could either make use of ellipsis here or restrict the number of characters for prefix/suffix

Environment

  • OS: [ Windows 10]
  • Camunda Modeler Version: [5.7.0 rc-1]
  • Execution Platform: [Camunda Cloud]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Jan 6, 2023
@nikku nikku added the Forms label Jan 6, 2023
@Skaiir Skaiir self-assigned this Jan 9, 2023
Skaiir added a commit to bpmn-io/form-js that referenced this issue Jan 9, 2023
Skaiir added a commit to bpmn-io/form-js that referenced this issue Jan 9, 2023
@Skaiir
Copy link
Contributor

Skaiir commented Jan 10, 2023

For now as a fix to this we have decided to simply truncate the text as we consider most scenarios of overflow as a misuse of the adorners in the first place, the PR for this is here.

As alternatives, we have considered restricting the width of the adorners and also restricting the length of the adorner text but since this is a problem that is very dependent on the viewport, we decided to leave users the freedom to write text that doesn't fit, as it is an edge case. In any case we'll truncate to keep it visually sensible, especially in the editor which has a pretty narrow viewport in preview mode.

@Skaiir
Copy link
Contributor

Skaiir commented Jan 10, 2023

@Skaiir Skaiir added this to the HTO iteration 13 milestone Jan 10, 2023
@nikku nikku added the backlog Queued in backlog label Jan 10, 2023 — with bpmn-io-tasks
Skaiir added a commit to bpmn-io/form-js that referenced this issue Jan 11, 2023
pinussilvestrus pushed a commit to bpmn-io/form-js that referenced this issue Jan 11, 2023
pinussilvestrus pushed a commit to bpmn-io/form-js that referenced this issue Jan 11, 2023
@pinussilvestrus
Copy link
Contributor

Fixed upstream via bpmn-io/form-js#489

@pinussilvestrus pinussilvestrus added fixed upstream Requires integration of upstream change and removed backlog Queued in backlog labels Jan 11, 2023
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 2, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the fixed upstream Requires integration of upstream change label Feb 2, 2023
@nikku
Copy link
Member

nikku commented Feb 2, 2023

Fixed via #3422.

As a user I'd expect the text to be cut off via ... instead of turning into multi-line. That could be a potential future improvement.

CC @pinussilvestrus @Skaiir

@Skaiir
Copy link
Contributor

Skaiir commented Feb 2, 2023

@nikku As the guy who thought he provided this exact fix me too :trollface:.

Is it turning into multi-line in the modeler integration then?

@nikku
Copy link
Member

nikku commented Feb 2, 2023

Not sure. Just reporting from a users standpoint. 🙈

@Skaiir
Copy link
Contributor

Skaiir commented Feb 2, 2023

Ah I see what's wrong, good find, some CSS changes clashed. Initially, it was behaving as you described.

Skaiir added a commit to bpmn-io/form-js that referenced this issue Feb 3, 2023
pinussilvestrus pushed a commit to bpmn-io/form-js that referenced this issue Feb 3, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 7, 2023
@nikku nikku modified the milestones: HTO iteration 13, M61 Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Forms
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants