Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYPI package errors #1

Closed
rroutsong opened this issue May 16, 2020 · 6 comments
Closed

PYPI package errors #1

rroutsong opened this issue May 16, 2020 · 6 comments

Comments

@rroutsong
Copy link

rroutsong commented May 16, 2020

package versioned at 0.0.3 on pypi throws import error

specifically throws error because of sklearn unvendoring of joblib:

File ".venv/lib/python3.6/site-packages/iso/learn.py", line 18, in <module>
    from sklearn.externals import joblib
ImportError: cannot import name 'joblib'

this version of learn.py is of a commit older than the tagged 0.0.3

@rroutsong rroutsong changed the title PYPI package disagrees with tagged v0.0.3 PYPI package errors May 16, 2020
@bprinty
Copy link
Owner

bprinty commented May 18, 2020

It seems like this has been resolved already:

https://github.com/bprinty/iso/blob/master/iso/learn.py#L15

I also tried installing the package in a virtualenv and didn't run into any errors:

~$ virtualenv -p python3 .venv
~$ source .venv/bin/activate
~$ pip install -r requirements.txt
>>> from iso import learn  ## success
>>> from iso.learn import Learner  ## success 

@rroutsong
Copy link
Author

rroutsong commented May 18, 2020

Yes it seems the version on pypi is different from the github current version though:

rroutsong@rroutsong-mbp:tmp]$ wget https://files.pythonhosted.org/packages/89/ee/72406a68904ad2fb8fa8288089569187024754da9f9334bf51dc418b4fee/iso-0.0.3.tar.gz
--2020-05-17 21:02:32--  https://files.pythonhosted.org/packages/89/ee/72406a68904ad2fb8fa8288089569187024754da9f9334bf51dc418b4fee/iso-0.0.3.tar.gz
Resolving files.pythonhosted.org (files.pythonhosted.org)... 2a04:4e42::319, 2a04:4e42:200::319, 2a04:4e42:400::319, ...
Connecting to files.pythonhosted.org (files.pythonhosted.org)|2a04:4e42::319|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 30479 (30K) [binary/octet-stream]
Saving to: ‘iso-0.0.3.tar.gz’

iso-0.0.3.tar.gz 100% [======================================>]  29.76K  --.-KB/s    in 0.02s

2020-05-17 21:02:32 (1.61 MB/s) - ‘iso-0.0.3.tar.gz’ saved [30479/30479]

[rroutsong@rroutsong-mbp:tmp]$ tar -zxf iso-0.0.3.tar.gz
[rroutsong@rroutsong-mbp:tmp]$ head -n 25 iso-0.0.3/iso/learn.py
# -*- coding: utf-8 -*-
#
# Learner utilities.
#
# @author <bprinty@gmail.com>
# ----------------------------------------------


# imports
# -------
import os
import re
import numpy
import warnings
import logging
from sklearn.base import BaseEstimator, clone
from sklearn.svm import SVC
from sklearn.externals import joblib
from sklearn.model_selection import train_test_split, KFold, LeaveOneOut, ShuffleSplit
from sklearn.exceptions import UndefinedMetricWarning
from sklearn import metrics
from gems import composite
from cached_property import cached_property

from .transform import TransformChain, Reduce

@bprinty
Copy link
Owner

bprinty commented May 18, 2020

Ah I see - I'll push a new version with the most recent version of the codebase.

@bprinty
Copy link
Owner

bprinty commented May 18, 2020

@bprinty bprinty closed this as completed May 18, 2020
@bprinty
Copy link
Owner

bprinty commented May 18, 2020

Thanks for the heads up!

@rroutsong
Copy link
Author

Thank you! Np this helps me a bunch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants