Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaysInStation wrong behavior #288

Open
Quacck opened this issue May 14, 2020 · 0 comments
Open

StaysInStation wrong behavior #288

Quacck opened this issue May 14, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Quacck
Copy link
Contributor

Quacck commented May 14, 2020

Describe the bug
Currently, the StaysInStation Pattern works by looking for a status=3 followed by a status=4.
This however creates wrong result as there could be status=3, status=5, .... status=5, status=4;
but this would still trigger the pattern.

Also it detects a unique transport by using the station_id and the train_id which doesn't really work.

Expected behavior
A StaysInStation should only trigger when status=3 is directly before status=4.
It should work on a per train basis, maybe we could implement it like CountOfTrainsInStation in the way that we apply it on a keyed stream.

@Quacck Quacck added the bug Something isn't working label May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant