Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude tests top-level package, add some JupyterLab trove classifiers #1513

Merged
merged 3 commits into from Aug 22, 2022

Conversation

bollwyvl
Copy link
Contributor

References

Code changes

  • removes the tests top-level module, which conflicts with other distributions
    • as it's "last-in-wins," this is not a reliable place to put them
    • some downstreams like constructor actively choke on them
  • adds some JupyterLab trove classifiers

User-facing changes

  • prospective users would be able to see bqplot in the PyPI browse UI when looking for JupyterLab extensions

Backwards-incompatible changes

  • n/a

@bollwyvl
Copy link
Contributor Author

The lint findings seem irrelevant... seems like a single-purpose PR running some formatters would be more helpful than anything else, with the appropriate git history flags to hide the churn.

@martinRenou martinRenou merged commit ce27e39 into bqplot:master Aug 22, 2022
@martinRenou
Copy link
Member

Thanks!

@martinRenou
Copy link
Member

meeseeksdev please backport to 0.12.x

meeseeksmachine pushed a commit to meeseeksmachine/bqplot that referenced this pull request Aug 22, 2022
martinRenou added a commit that referenced this pull request Aug 22, 2022
…3-on-0.12.x

Backport PR #1513 on branch 0.12.x (exclude tests top-level package, add some JupyterLab trove classifiers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants