Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove top-level tests module, clean up host deps, test metadata with CLI #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove top-level tests module, clean up host deps, test metadata with CLI #86

wants to merge 2 commits into from

Conversation

bollwyvl
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Changes:

  • remove tests top-level module which causes ClobberErrors in e.g. constructor
  • clean up host dependencies
  • clean up some variables
  • use CLI and (m2-)grep in tests for activation

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bollwyvl
Copy link
Author

@conda-forge-admin please rerender

@bollwyvl bollwyvl marked this pull request as ready for review August 10, 2022 20:46
@bollwyvl
Copy link
Author

@conda-forge/bqplot ready for review

@bollwyvl bollwyvl mentioned this pull request Aug 13, 2022
Merged
@bollwyvl
Copy link
Author

Also opened bqplot/bqplot#1513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

@ibdafna ibdafna Awaiting requested review from ibdafna ibdafna is a code owner

@jasongrout jasongrout Awaiting requested review from jasongrout jasongrout is a code owner

@martinRenou martinRenou Awaiting requested review from martinRenou martinRenou is a code owner

@rmenegaux rmenegaux Awaiting requested review from rmenegaux rmenegaux is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bollwyvl @conda-forge-linter