Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log console messages in UI-tests + fix visual regression tests #1572

Merged
merged 7 commits into from
Feb 2, 2023

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou martinRenou changed the title Log console messages in UI-tests Log console messages in UI-tests + fix visual regression tests Feb 2, 2023
@martinRenou
Copy link
Member Author

@mariobuikhuizen @maartenbreddels visual regression tests passing again! I think we were facing jupyter-widgets/ipywidgets#3549 and updating the yarn.lock did the trick

@martinRenou martinRenou merged commit 2339e13 into bqplot:master Feb 2, 2023
@martinRenou martinRenou deleted the log_messages_playwright branch February 2, 2023 16:37
@maartenbreddels
Copy link
Member

Great to hear!
What makes you think jupyter-widgets/ipywidgets#3549 was the problem? Note that I found out today this was also present in widgets 7 jupyter-widgets/ipywidgets#3687

@martinRenou
Copy link
Member Author

What makes you think jupyter-widgets/ipywidgets#3549 was the problem?

I'm not entirely sure this was the culprit. But we've seen very similar symptoms in ipyleaflet jupyter-widgets/ipyleaflet#968 (comment): issue in fetching some sub-widget state and not reproducible outside of Galata. So that's what makes me think it's the reason.

@mariobuikhuizen
Copy link
Contributor

Thanks for the notification @martinRenou! I've updated #1539, which now has no visual regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants