fix: deserialize state before updating model on reconnect #3687
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #3549 from 8.x to the 7.x branch.
When jupyterlab resumes from a sleeping computer, it will reconnect, and instead of creating the new comms, it will update the models. Like #3549 we did not deserialize the state in this rare condition. This caused a model widget to be passed as a string, which later on caused
model.state_change.then
to fail, since model.state_change is undefined. On the js console, it would show:This caused widgets not to appear.
Privately reported, and also likely the cause of spacetelescope/jdaviz#1977.