Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding Protocol lockfile results in annotations #1

Closed
haydenbleasel opened this issue Dec 16, 2022 · 1 comment
Closed

Rebuilding Protocol lockfile results in annotations #1

haydenbleasel opened this issue Dec 16, 2022 · 1 comment

Comments

@haydenbleasel
Copy link

haydenbleasel commented Dec 16, 2022

Sorry that this is specific to the Protocol template, however it's the only use case I have for this issue.

Essentially what's happening is that with a fresh download of the Protocol template, the specific deps listed in the lockfile work perfectly. However, if the lockfile is rebuilt (or you switch to a different package manager), there's an issue with mdx-annotations where it can successfully identify annotations and apply the annotation prop, but it's can't replace them with actual properties later on.

I went into a messy deep dive on Twitter. Seeing as it's dependency version based, I'm guessing it's based on an upgrade to an underlying dependency not directly listed. The diff o the thread might help. In terms of actually fixing it, I think the answer might lie in the recma transformer. Happy to do more digging if it helps. I'd be curious to see what the answer is!

✌️

@bradlc bradlc closed this as completed in 1595aee Dec 17, 2022
@bradlc
Copy link
Owner

bradlc commented Dec 17, 2022

Fixed in v0.1.1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants