Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated usage of STATIC_URL #384

Merged
merged 1 commit into from
Sep 23, 2016
Merged

Deprecated usage of STATIC_URL #384

merged 1 commit into from
Sep 23, 2016

Conversation

velaia
Copy link
Contributor

@velaia velaia commented Sep 16, 2016

According to the Django documentation and the attached article use of STATIC_URL creates trouble with some storages. It didn't work for me under 1.10.1 at all:
https://docs.djangoproject.com/en/1.10/howto/static-files/#configuring-static-files
http://staticfiles.productiondjango.com/blog/stop-using-static-url-in-templates/

According to the Django documentation and the attached article use of STATIC_URL creates trouble with some storages. It didn't work for me under 1.10.1 at all:
https://docs.djangoproject.com/en/1.10/howto/static-files/#configuring-static-files
http://staticfiles.productiondjango.com/blog/stop-using-static-url-in-templates/
@jieter
Copy link
Owner

jieter commented Sep 16, 2016

Can you also have a look at the other occurances: https://github.com/bradleyayers/django-tables2/search?utf8=✓&q=STATIC_URL

@jieter jieter merged commit 0e67982 into jieter:master Sep 23, 2016
jieter added a commit that referenced this pull request Sep 23, 2016
@jieter
Copy link
Owner

jieter commented Sep 23, 2016

@velaia please be careful while adding these kinds of changes in the blind. Only when I started to amend the other occurrences of STATIC_URL, it turned out your change used the wrong name: static, not staticfiles.

Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants