-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working #10
Comments
See if that works, I haven't had time to add the Z order to the plugin to fix this. I also need to confirm with the team what changed since 1.5 when it was working. |
Just updated the plugin on npm with the added code for Android to make it visible due to a layering issue with the views. |
@bradmartin there is one caveat though, Z order puts the video on top of everything! For example, if you want to have subtitles showing over the video it won't work. Due to the Z order, the video will appear on top of the label with subs no matter what you do :( |
@bradmartin do you have an idea what the layering issue is exactly? is there another solution other than the ZOrderOnTop which would allow us to draw elements on top of the video? |
@MiroValchev @Ivshti - I don't know the exact issue. It was not an issue with NativeScript 1.5, the time I developed the plugin. I've asked the team what possibly changed with the layouts/page to cause the issue and they said it was present with 1.5, which it must be a device/android api issue if that's the case because I developed and tested it fine with NS 1.5. As for using |
@bradmartin well I think it's related to the version. We all kept testing with the same emulators/images/conditions, only thing that changed was {N} version. Can you point us to whomever you asked and maybe tag them in this thread? It doesn't render if we don't use |
Hey @Ivshti, Actually I've suggested to @MiroValchev and @bradmartin to use this setting based on this thread: We've tested locally with simple Placeholder and VideoView in 1.5 and the issue was present. Here is an example: <Page>
<Placeholder creatingView="creatingView" />
</Page> exports.creatingView = function (args) {
var v = new android.widget.VideoView(args.context);
v.setVideoURI(android.net.Uri.parse("http://clips.vorwaerts-gmbh.de/big_buck_bunny.mp4"));
// v.setZOrderOnTop(true);
v.requestFocus();
v.start();
args.view = v;
} |
Hey folks, You are right! Please accept my excuses! I've finally replicated the problem and we will do our best to find immediately what's going on and how to fix it. |
You can monitor this issue: |
@bradmartin thanks for confirming it |
I've just updated the issue in our repo with a possible workaround. Can you try it and let me know if this will work for you? |
@enchev thanks for the idea, we'll try it and inform you very soon |
@bradmartin |
@bathejasumeet we use a fork of nativescript-video for a production app, and we had the same case with 1.5 vs 1.6/1.7; we worked it around by reverting to 1.5, but after we complete our alpha release we will be also available to help for resolving the issue. See this -> NativeScript/NativeScript#1874 for the progress |
@bradmartin @Ivshti @enchev
Can we reverse engineer this? |
@enchev , I think we should target for achieving this behavior in interim, I mean trying to make the view with controls float over the VideoView like MediaController does. |
@bathejasumeet - I meant to build this plugin with that as an option, to put the controls on top of the VideoView. I think I just forgot about it after my test run before making the actual android side of the plugin :) If you want to submit a PR with an optional attribute to set the controls on top of the VideoView that would be great. I'll create an issue with this as something needing to be done so it's not lost. I also need to add a full screen option, again, just something I didn't have time to fully implement and NS needed a video plugin for devs less familiar with native controls so I wanted to ship it once it was decently functional. |
@bradmartin I can confirm that this has been fixed in {N} 2.1. Still, you have to remove the hack: this._android.setZOrderOnTop(true); |
Thanks for confirming. I'll update the package. On Tue, Jul 5, 2016, 7:19 AM Miro notifications@github.com wrote:
|
Just published the update. |
doesnt matter what i do the screen is all white, i only can hear the video but cant see it.
The text was updated successfully, but these errors were encountered: