Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping controls #401

Closed
ShiranAbir opened this issue Nov 30, 2022 · 3 comments · Fixed by #402
Closed

Overlapping controls #401

ShiranAbir opened this issue Nov 30, 2022 · 3 comments · Fixed by #402
Labels

Comments

@ShiranAbir
Copy link
Contributor

When adding multiple card providers, the controls and text can overlap the cards as shown below:
Screenshot_20221130_125923

@ShiranAbir
Copy link
Contributor Author

While I was trying a fix, I learned that the controls are React-Bootstrap controls.
Searching the affected Stack controller, it seems that the previous gap ({5}) is the biggest builtin-gap possible:
https://react-bootstrap.github.io/layout/stack/#:~:text=Sets%20the%20spacing%20between%20each%20item.%20Valid%20values%20are%200%2D5.

This required me to creat a custom gap CSS class which will have adequate gap for the controls has seen below:
Screenshot_20221130_125942

@baruchiro
Copy link
Collaborator

While I was trying a fix, I learned that the controls are React-Bootstrap controls. Searching the affected Stack controller, it seems that the previous gap ({5}) is the biggest builtin-gap possible: https://react-bootstrap.github.io/layout/stack/#:~:text=Sets%20the%20spacing%20between%20each%20item.%20Valid%20values%20are%200%2D5.

This required me to creat a custom gap CSS class which will have adequate gap for the controls has seen below: Screenshot_20221130_125942

Hi @ShiranAbir, I think next time, a comment about doubt in the final implementation should be in the PR and not in the issue.

Thank you!!!

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants