Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync type parameters can be required #39

Closed
mitar opened this issue Nov 2, 2019 · 2 comments · Fixed by #41
Closed

Sync type parameters can be required #39

mitar opened this issue Nov 2, 2019 · 2 comments · Fixed by #41

Comments

@mitar
Copy link
Member

mitar commented Nov 2, 2019

@toomim In this change you wrote that parameters are optional. That is not necessary true. You can define both required and optional parameters (in registration form you define both sets).

@toomim
Copy link
Member

toomim commented Nov 3, 2019

My reading of that paragraph is about the definition of a Sync Type, not the use of a Sync Type. It is optional for a Sync Type to specify parameters. If it chooses to do so, it can certainly require one of those parameters to be specified when it is used on a resource.

In any case, I'm open to whatever language makes this clearer.

@mitar
Copy link
Member Author

mitar commented Nov 3, 2019

Yes, at the end I decided to remove mention of parameters in that paragraph, because I could not find a language which would differentiate between two meanings of optional there. If you think parameters should be defined there, maybe we can use "can have parameters" language. Can makes it optional.

@mitar mitar closed this as completed in #41 Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants