Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'hemisphere' option to heatmap() #27

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

carlocastoldi
Copy link
Contributor

Description

This small PR adds the hemisphere option in order to plot only the right, left or both hemispheres.
This can be useful when comparing two different but symmetrical data.

  • Bug fix
  • Addition of a new feature
  • Other

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f9e7f90) 0.00% compared to head (d0ce373) 0.00%.

Files Patch % Lines
brainglobe_heatmap/heatmaps.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #27   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          5       5           
  Lines        285     285           
=====================================
  Misses       285     285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson
Copy link
Member

@carlocastoldi does this work for you? Trying it out locally I get AttributeError: 'Mesh' object has no attribute 'cutWithPlane' with every example, unless hemisphere="false".

@alessandrofelder alessandrofelder requested review from adamltyson and removed request for alessandrofelder December 20, 2023 15:06
@alessandrofelder
Copy link
Member

I get the same as Adam 🤔

@carlocastoldi
Copy link
Contributor Author

yes, this PR depends on brainglobe/brainrender#304

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlocastoldi, this will be very useful. I'll release a new version of brainrender, then release this.

@adamltyson adamltyson merged commit 65a4b2d into brainglobe:main Dec 21, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants