Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some vedo function calls still using lowerCamelCase instead of snake_case #304

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

carlocastoldi
Copy link
Contributor

6a7ca30 should have probably updated centerOfMass to center_of_mass in the whitelisted attributes of Actor.__getattr__()

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3dfb742) 86.23% compared to head (8f0bec7) 86.39%.
Report is 3 commits behind head on main.

Files Patch % Lines
brainrender/scene.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   86.23%   86.39%   +0.16%     
==========================================
  Files          26       26              
  Lines        1213     1213              
==========================================
+ Hits         1046     1048       +2     
+ Misses        167      165       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adamltyson adamltyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks both!

@adamltyson adamltyson merged commit 88cdcc3 into brainglobe:main Dec 21, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants