Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting of user-dependent FXAA vedo setting #283

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

alessandrofelder
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Brainrender examples don't render correctly on some machines - see #240 and related forum discussion

What does this PR do?
Removes the explicit setting of a vedo setting that messes with rendering.

References

Closes #240

How has this PR been tested?

Local running of

import brainrender
scene=brainrender.Scene(atlas_name="allen_mouse_25um")
scene.render()

Is this a breaking change?

Yes, if anyone was relying on use_FXAA being set to true.

Does this PR require an update to the documentation?

Don't think this was documented anywhere in the first place, so not specifically?

Checklist:

  • The code has been tested locally (manually)
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Nov 28, 2023
@alessandrofelder alessandrofelder marked this pull request as ready for review November 28, 2023 17:41
@adamltyson
Copy link
Member

Would it not be better to just change the default so that users can change this within brainrender settings?

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69a2aea) 86.39% compared to head (b304bc2) 86.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##           mega-fix     #283   +/-   ##
=========================================
  Coverage     86.39%   86.39%           
=========================================
  Files            26       26           
  Lines          1205     1205           
=========================================
  Hits           1041     1041           
  Misses          164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder
Copy link
Member Author

alessandrofelder commented Nov 28, 2023

Would it not be better to just change the default so that users can change this within brainrender settings?

Sure, makes it more explicit what we expect users might want to change (think they can change everything anyway though, if they know what settings vedo has).

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@IgorTatarnikov IgorTatarnikov merged commit a5af51c into mega-fix Nov 28, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants