Tiny improvement to contributing guide #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mega-fix #284 +/- ##
=========================================
Coverage 86.39% 86.39%
=========================================
Files 26 26
Lines 1205 1205
=========================================
Hits 1041 1041
Misses 164 164 ☔ View full report in Codecov by Sentry. |
adamltyson
reviewed
Nov 29, 2023
| @@ -27,7 +27,7 @@ pip install brainrender | |||
| ``` | |||
|
|
|||
| ## Contributing | |||
| Contributions to brainrender are more than welcome. Please see the [developers guide](https://brainglobe.info/developers/index.html). | |||
| Contributions to brainrender are more than welcome. Please see the [developers guide](https://brainglobe.info/community/developers/index.html). Note that some tests are only run locally, by specifying `--runslow --runlocal` in `pytest`. | |||
There was a problem hiding this comment.
A suggestion for the future (i.e. not to be addressed now, but maybe should be an issue). Should this be inverted, so all the tests run by default, but we only pick the fast ones for CI?
There was a problem hiding this comment.
Opened #285 for this
This was referenced Nov 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
What does this PR do?
References
Closes #253