Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets don't show properly on macOS #341

Closed
adamltyson opened this issue Jun 18, 2021 · 6 comments · Fixed by #357
Closed

Widgets don't show properly on macOS #341

adamltyson opened this issue Jun 18, 2021 · 6 comments · Fixed by #357
Assignees
Labels
cellfinder-napari Issue concerns the napari plugin

Comments

@adamltyson
Copy link
Member

Bottom (e.g. run) buttons can't be seen on small screens.

@adamltyson adamltyson self-assigned this Jun 18, 2021
@adamltyson adamltyson removed their assignment Feb 14, 2022
@dstansby
Copy link
Member

dstansby commented Mar 3, 2022

I dived into magicgui and couldn't obviously find a way to fix this, so I've opened https://github.com/napari/magicgui/issues/380 to ask about being able to resize widgets.

@dstansby
Copy link
Member

Fixed by brainglobe/cellfinder-napari#79

@dstansby dstansby self-assigned this Mar 30, 2022
@adamltyson
Copy link
Member Author

I'm reopening this as the problem appears to be back.

@dstansby
Copy link
Member

Some background on where I left this, which might be helpful:

  • My first attempt at adding scroll support didn't work with napari
  • I opened a second magicgui PR to fix this (https://github.com/napari/magicgui/pull/429). This PR has been merged, but not put into a release of magicgui, so action here is to nudge Tally to do a release
  • I think once that's release there also needs to be a change in napari to use the new root_native_widget property that I added in the above PR. I don't think I got round to that, so action there is to open a PR in napari (once a new magicgui version is released

@adamltyson
Copy link
Member Author

Thanks for the clarification @dstansby.

Naively, I assumed that either using scrollable=True or using the unofficial API (#79) would allow a scrollable widget. I haven't dug into why, but both seem to be required, do you know why?

@dstansby dstansby removed their assignment Apr 24, 2023
@adamltyson
Copy link
Member Author

This still needs to be addressed for the curation and training widget.

@alessandrofelder alessandrofelder self-assigned this Dec 6, 2023
@willGraham01 willGraham01 added the cellfinder-napari Issue concerns the napari plugin label Jan 3, 2024
@willGraham01 willGraham01 transferred this issue from brainglobe/cellfinder-napari Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cellfinder-napari Issue concerns the napari plugin
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants