Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

Use official scrollable widget #136

Merged
merged 8 commits into from
Oct 14, 2022
Merged

Use official scrollable widget #136

merged 8 commits into from
Oct 14, 2022

Conversation

adamltyson
Copy link
Member

@adamltyson adamltyson commented Sep 12, 2022

Addresses brainglobe/cellfinder#341 & #122.

Thanks to @dstansby's hard work 🙏

Closing #135 in favour of this as I messed up the Git history.

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Sep 12, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/brainglobe/cellfinder-napari/136
Updated: 2022-10-14T14:39:24.426864

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 95.42% // Head: 95.40% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (4c87fa2) compared to base (e2d73a3).
Patch has no changes to coverable lines.

❗ Current head 4c87fa2 differs from pull request most recent head 5ba2b6f. Consider uploading reports for the commit 5ba2b6f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     brainglobe/cellfinder-napari#136      +/-   ##
==========================================
- Coverage   95.42%   95.40%   -0.02%     
==========================================
  Files          17       17              
  Lines         808      805       -3     
==========================================
- Hits          771      768       -3     
  Misses         37       37              
Impacted Files Coverage Δ
cellfinder_napari/detect/detect.py 93.10% <ø> (-0.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adamltyson
Copy link
Member Author

Maybe not. This doesn't work for me locally anymore ...

@adamltyson
Copy link
Member Author

For some reason this is still required. I'd assumed scrollable=True should suffice.

    scroll = QScrollArea()
    scroll.setWidget(widget._widget._qwidget)
    widget._widget._qwidget = scroll

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamltyson
Copy link
Member Author

This is failing on some Python versions, but with a known napari issue ( E ModuleNotFoundError: No module named 'imageio_ffmpeg') so merging anyway. Should be fixed with the next release of napari.

@adamltyson adamltyson merged commit a0feac2 into main Oct 14, 2022
@adamltyson adamltyson deleted the scrollable branch October 14, 2022 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant