Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manual version #241

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Update manual version #241

merged 2 commits into from
Aug 2, 2023

Conversation

willGraham01
Copy link
Collaborator

Apologies for the PR noise.

New version in setup.py for patched version, so we can release v0.7.0 to PyPI.

There look to be old tags (v0.6.0) that are datestamped 2020, but the latest releases are from 2021 and only reach v0.4.21.

Bumping to version v0.7.0 to skip around this ambiguity. Will generate release notes once pushed to PyPI.

Before submitting a pull request (PR), please read the contributing guide.

New version in setup.py for patched version.

There look to be old tags (v0.6.0) that are datestamped 2020, but the latest releases are from 2021 and only reach v0.4.21.

Bumping to version `v0.7.0` to skip around this ambiguity. Will generate release notes once pushed to PyPI.
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2f468f3) 18.92% compared to head (410d433) 18.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #241   +/-   ##
=======================================
  Coverage   18.92%   18.92%           
=======================================
  Files          25       25           
  Lines        1495     1495           
=======================================
  Hits          283      283           
  Misses       1212     1212           
Files Changed Coverage Δ
cellfinder/__init__.py 0.00% <0.00%> (ø)
setup.py 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamltyson
Copy link
Member

@willGraham01 this package still uses bump2version to update versions (it hasn't get been migrated to setuptools_scm. I think bump2version minor should update the version in all the right places.

@adamltyson
Copy link
Member

If not, the version just also needs updating in cellfinder/__init__.py

@willGraham01
Copy link
Collaborator Author

If not, the version just also needs updating in cellfinder/init.py

bump2version agrees - things should match up now.

Have opened #242 to remind me to update the versioning method.

@adamltyson adamltyson merged commit 7787e38 into main Aug 2, 2023
15 of 16 checks passed
@adamltyson adamltyson deleted the willGraham01-bump-version branch August 2, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants