Dialog - useBodyOnScroll - Fix for nested dialogs case #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzimowski
requested review from
krzotki,
Fasosnql and
radekwarisch
as code owners
bartoszlorek
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
I would implement the useBodyNoScroll with the context to be aware of the nested state. https://www.aleksandrhovhannisyan.com/blog/react-context-nested-components/
krzotki
approved these changes
Jan 16, 2024
👌 i created this #2795 issue to handle it the way you suggested, thank you! |
matzimowski
deleted the
Dialog---useBodyOnScroll---Fix-for-nested-dialogs
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
two dialogs are open. one is nested in another. both are closed at the same time.
"sg-dialog-no-scroll"class is not removed from the document body and the whole page cannot be scrolled (due tomanyDialogsOpenedcondition).after
two dialogs are open. one is nested in another. both are closed at the same time.
"sg-dialog-no-scroll"class is removed from the document body and the whole page is working as expected.Note:
An Issue created to introduce an ultimate solution for nested components