Skip to content
This repository has been archived by the owner on May 16, 2022. It is now read-only.

Improvements in parsing TTF Fonts #20

Closed
ashutosh1211 opened this issue Jun 21, 2020 · 0 comments
Closed

Improvements in parsing TTF Fonts #20

ashutosh1211 opened this issue Jun 21, 2020 · 0 comments

Comments

@ashutosh1211
Copy link

You have written very good parser, it works.
While parsing TTF font i observed few issues or missing code as follow.

  1. While parsing lookups of type 7 , offset is not added.

    data = gsub.LookupType(buffer, extensionLookupType, extensionOffset);

    Here we need to add offset of current lookup.

  2. Do not read markFilteringSet if LookupFlag is not set.

    var markFilteringSet = buffer.read(Type.USHORT);

    Reference: https://docs.microsoft.com/en-us/typography/opentype/spec/chapter2#lookupTbl

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants