Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character-timed delay syntax is displayed if included in end-on string #15

Closed
greyskin opened this issue Mar 12, 2023 · 5 comments
Closed

Comments

@greyskin
Copy link

Including a character-timed delay in an end-on string results in the code being displayed.

Example:

.test {
    @include typed(
        "Testing...",
        1,
        (
            iterations: 1,
            end-on: "one, two and... <[15]>three")
    );
}

Results in the end-on string being temporarily displayed as:

one, two and... <[15]

before the "<[15]" disappears and the correct string is displayed:

one, two and... three

@greyskin
Copy link
Author

greyskin commented Mar 12, 2023

On further testing, it appears the character-timed delay syntax is also displayed in standard strings if the iterations property is set to 0.

Not sure if that additional info is useful in identifying the cause of this.

I'm using Chrome Version 110.0.5481.180 (Official Build) (64-bit)

@greyskin greyskin changed the title Character-timed delay is displayed if included in end-on string Character-timed delay syntax is displayed if included in end-on string Mar 12, 2023
@brandonmcconnell
Copy link
Owner

@greyskin Hey Luke, thanks for the report. I'm pretty swamped with work-work at the moment, but I'll try to get a fix for this in the next week or two. Really appreciate it!

@brandonmcconnell
Copy link
Owner

@greyskin It turned out to be a much simpler fix than I expected.

Resolved via commit 53c86a

@brandonmcconnell
Copy link
Owner

@greyskin Please test and let me know if this update fixes the issue for you!

@greyskin
Copy link
Author

@brandonmcconnell yes this fixed it! 👍 Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants