Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a Brave to Brave Wallet Drain Job #611

Merged
merged 13 commits into from
Dec 16, 2020
Merged

Adding a Brave to Brave Wallet Drain Job #611

merged 13 commits into from
Dec 16, 2020

Conversation

husobee
Copy link
Contributor

@husobee husobee commented Dec 11, 2020

Summary

Adds a new drain queue for brave to brave wallet draining.

Type of change ( select one )

  • Product feature
  • Bug fix
  • Performance improvement
  • Refactor
  • Other

Tested Environments

  • Development
  • Staging
  • Production

Before submitting this PR:

  • Does your code build cleanly without any errors or warnings?
  • Have you used auto closing keywords?
  • Have you added tests for new functionality?
  • Have validated query efficiency for new database queries?
  • Have documented new functionality in README or in comments?
  • Have you squashed all intermediate commits?
  • Is there a clear title that explains what the PR does?
  • Have you used intuitive function, variable and other naming?
  • Have you requested security / privacy review if needed
  • Have you performed a self review of this PR?

Manual Test Plan:

@husobee husobee self-assigned this Dec 11, 2020
@bsclifton bsclifton mentioned this pull request Dec 11, 2020
Merged
23 tasks
evq
evq previously requested changes Dec 11, 2020
View reviewed changes
promotion/datastore.go Outdated Show resolved Hide resolved
@husobee husobee requested a review from evq December 14, 2020 16:31
@husobee husobee force-pushed the mint_drain branch 2 times, most recently from 1a3f7e8 to facc77c Compare December 14, 2020 20:22
@husobee husobee merged commit 67aa0c3 into master Dec 16, 2020
@husobee husobee deleted the mint_drain branch December 16, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maikelmclauflin maikelmclauflin maikelmclauflin approved these changes

@evq evq Awaiting requested review from evq

Assignees

@husobee husobee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@husobee @maikelmclauflin @evq