New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the QR code in Brave Rewards (brave://rewards) #7413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Partially blocked on brave-intl/bat-go#611 |
Restarting
|
Fixes brave/brave-browser#13159 ---------- Revert "Merge pull request #7350 from brave/bsc-remove-qr-code" This reverts commit 858ca76, reversing changes made to ba5983c.
cb23101
to
4cb2693
Compare
iOS failing is not related to this; created brave/brave-browser#13210 to cover that |
awesome, thanks for getting this PR in good shape @bsclifton 👍 As soon as we're done with https://github.com/brave/internal/issues/739, we'll get it merged. |
Fixes brave/brave-browser#13159
Revert "Merge pull request #7350 from brave/bsc-remove-qr-code"
This reverts commit 858ca76, reversing
changes made to ba5983c.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: