Merge pull request #1469 from brave/mac-installer-sign-pkg

Add options for installer signing key on Mac
brave · Oct 11, 2018 · 17fac2a · 17fac2a
2 parents 5614591 + bf5841c
commit 17fac2a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/lib/config.js b/lib/config.js
@@ -43,6 +43,7 @@ const Config = function () {
   this.chromeVersion = getNPMConfig(['projects', 'chrome', 'tag']) || '0.0.0.0'
   this.releaseTag = this.braveVersion.split('+')[0]
   this.mac_signing_identifier = getNPMConfig(['mac_signing_identifier']) || ''
+  this.mac_installer_signing_identifier = getNPMConfig(['mac_installer_signing_identifier']) || ''
   this.mac_signing_keychain = getNPMConfig(['mac_signing_keychain']) || 'login'
   this.channel = ''
   this.sccache = getNPMConfig(['sccache'])
@@ -87,6 +88,7 @@ Config.prototype.buildArgs = function () {
 
   if (process.platform === 'darwin') {
     args.mac_signing_identifier = this.mac_signing_identifier
+    args.mac_installer_signing_identifier = this.mac_installer_signing_identifier
     args.mac_signing_keychain = this.mac_signing_keychain
   }
 
@@ -262,6 +264,9 @@ Config.prototype.update = function (options) {
   if (options.mac_signing_identifier)
     this.mac_signing_identifier = options.mac_signing_identifier
 
+  if (options.mac_installer_signing_identifier)
+    this.mac_installer_signing_identifier = options.mac_installer_signing_identifier
+
   if (options.mac_signing_keychain)
     this.mac_signing_keychain = options.mac_signing_keychain
 

diff --git a/scripts/commands.js b/scripts/commands.js
@@ -45,6 +45,7 @@ program
   .option('-C <build_dir>', 'build config (out/Debug, out/Release')
   .option('--target_arch <target_arch>', 'target architecture', 'x64')
   .option('--mac_signing_identifier <id>', 'The identifier to use for signing')
+  .option('--mac_installer_signing_identifier <id>', 'The identifier to use for signing the installer')
   .option('--mac_signing_keychain <keychain>', 'The identifier to use for signing', 'login')
   .option('--debug_build <debug_build>', 'keep debugging symbols')
   .option('--official_build <official_build>', 'force official build settings')