Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Fix deps in //brave/components/content_settings/core/browser/* #10627

Open
jumde opened this issue Jul 8, 2020 · 0 comments
Open

Comments

@jumde
Copy link
Contributor

jumde commented Jul 8, 2020

$ gn check . //brave/components/content_settings/core/browser/*
ERROR at //brave/components/content_settings/core/browser/brave_content_settings_ephemeral_provider.h:11:11: Include not allowed.
#include "components/content_settings/core/browser/content_settings_ephemeral_provider.h"
          ^-----------------------------------------------------------------------------
It is not in any dependency of
  //brave/components/content_settings/core/browser:browser
The include file is in the target(s):
  //components/content_settings/core/browser:browser
which should somehow be reachable.
___________________
ERROR at //brave/components/content_settings/core/browser/brave_content_settings_pref_provider.h:15:11: Include not allowed.
#include "components/content_settings/core/browser/content_settings_observer.h"
          ^-------------------------------------------------------------------
It is not in any dependency of
  //brave/components/content_settings/core/browser:browser
The include file is in the target(s):
  //components/content_settings/core/browser:browser
which should somehow be reachable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant