Upgrade from Chromium 85 to Chromium 86.

[mkarolin]

Upgrade from Chromium 85.0.4183.38 to Chromium 86.0.XX.YY

https://chromium.googlesource.com/chromium/src/+log/85.0.4183.38..86.0.4205.3/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Affected areas:
TBD

[GeetaSarvadnya]

Verification passed on

Brave | 1.16.19 Chromium: 86.0.4240.30 (Official Build) nightly (64-bit)
-- | --
Revision | 09f50eb5535879364cf00e72653462a509ef6bdc-refs/branch-heads/4240@{#552}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

• Encountered Trackers & Ads Blocking Setting Not Persisting #11585 (comment), [Desktop] Remove Chromium cookie flyouts  #11709
• Logged Chrome incognito icon is used in allow cookies sites list #11738, Branding issues in CR 86 #11757, Vimeo publishers video flickering issue in brave #11762

1. Brave://settings/cookies verifications

• Verified that new chromium cookies setting are added in brave://settings/cookies
  

• Verified that shortcut Cookies and other site data settings option is provided under brave://settings/privacy to navigate to brave://settings/cookies
  

• Navigate to brave://settings/content and click on Cookies and site data and verified that it's redirecting to brave://settings/cookies

1.1 Cookies and other site data settings verifications

1. Change cookies settings from brave://settings/cookies and verify the changes are reflected in brave://settings/shields

• Clean profile 1.16.x and navigate to brave://settings/cookies and enable Allow all cookies settings
• Ensured that Allow all cookies radio button is selected in brave://settings/cookies
• Open brave://settings/shields and ensured that cookings blocking settings is reflected as Disabled
• Open a site cnn.com and click on Advanced shield settings and ensured that All cookies are allowed selected in the dropdown
• Enable Block third-party cookies cookies settings in brave://settings/cookies
• Ensured that cookies blocking settings is reflected as Only cross-site in brave://settings/shields
• Open a site cnn.com and click on Advanced shield settings and ensured that Cross site cookies blocked selected in the dropdown
• Enable Block all cookies cookies settings in brave://settings/cookies
• Ensured that cookies blocking settings is reflected as All in brave://settings/shields
• Open a site cnn.com and click on Advanced shield settings and ensured that Cookies blocked selected in the dropdown

2. Change cookies settingsfrom brave://settings/shields and verify changes are reflected in brave://settings/cookies

• Clean profile 1.16.x and navigate to brave://settings/shields and select Disabled cookies settings
• Ensured that Allow all cookies radio button is selected in brave://settings/cookies
• Open a site cnn.com and click on Advanced shield settings and ensured that All cookies are allowed selected in the dropdown
• Select only cross sites cookies settings in brave://settings/shields
• Ensured that Block third-party cookies radio button is selected in brave://settings/cookies
• Open a site cnn.com and click on Advanced shield settings and ensured that Cross site cookies blocked selected in the dropdown
• Select All cookies settings in brave://settings/shields
• Ensured that Block all cookies radio button is selected in brave://settings/cookies
• Open a site cnn.com and click on Advanced shield settings and ensured that Cookies blocked selected in the dropdown

3. Upgrade scenario

• Clean profile 1.14.x and upgrade profile to 1.16.x and ensured that the default cookies settings is retained in brave://settings/cookies
• Clean profile 1.14.x and set the cookies settings to All in brave://settings/shields and upgrade profile to 1.16.x and ensured that the Block all cookies option is selected in brave://settings/cookies
• Clean profile 1.14.x and set the cookies settings to Disabled in brave://settings/shields and upgrade profile to 1.16.x and ensured that the Allow all cookies option is selected in brave://settings/cookies

4. Sites that can never use cookies
Scenario 1:

• Set/select all cookies block in brave://settings/cookies
• Ensure all cookies blocked in brave://settings/shields and All is selected in cookies blocking dropdown
• Ensure social media blocking settings are enabled
• Add a site https://www.nytimes.com to Sites that can never use cookies list in brave://settings/cookies
• Open https://www.nytimes.com in a NTP

---> Reload the NYTimes tab and click on the lock icon in the URL bar and ensured that Cookies (1 in use) shown ( Note: which is expected as cookies allowed list shows google.com which is leaked from one of the social media blocking settings and social media settings override the global shield settings)

Scenario 2:

• Set/select all cookies block in brave://settings/cookies
• Ensure all cookies blocked in brave://settings/shields and All is selected in cookies blocking dropdown
• Diable all social media blocking settings
• Add a site https://www.nytimes.com to Sites that can never use cookies list in brave://settings/cookies
• Open https://www.nytimes.com in an NTP

---> Reload the NYTimes tab and click on the lock icon in the URL bar and ensured that Cookies (0 in use) shown ( Note: which is expected as social media blocking settings are disabled)

5. Sites that can always use cookies
Scenario 1:

• Set/select all cookies block in brave://settings/cookies
• Ensure all cookies blocked in brave://settings/shields and All is selected in cookies blocking dropdown
• Ensure social media blocking settings are enabled
• Add a site https://www.nytimes.com to Sites that can always use cookies list in brave://settings/cookies
• Open https://www.nytimes.com in an NTP

---> Reload the NYTimes tab and click on the lock icon in the URL bar and ensured that Cookies (10 in use) is shown

Scenario 2:

• Set/select all cookies block in brave://settings/cookies
• Ensure all cookies blocked in brave://settings/shields and All is selected in cookies blocking dropdown
• Disable all social media blocking settings
• Add a site https://www.nytimes.com to Sites that can always use cookies list in brave://settings/cookies
• Open https://www.nytimes.com in an NTP

---> Reload the NYTimes tab and click on the lock icon in the URL bar and ensured that Cookies (9 in use) is shown

6. Always clear cookies when windows are closed

1. Clean profile 1.16.x
2. Add [*.]cnn.com to the list Always clear cookies when windows are closed in brave://settings/cookies
3. Open cnn.com and buzzfeed.com in NTP's
4. Open brave://settings/siteData and ensure cookies and site data is stored for both sites cnn.com and buzzfeed.com
5. Open brave://settings/content/all and ensure cookies and site data is stored for both sites cnn.com and buzzfeed.com
6. Close the tabs where cnn.com and buzzfeed is opened
7. Quit brave and restart

----> Ensured that cookies and site data for CNN.com is removed from brave://settings/siteData and brave://settings/content/all
----> Ensured that cookies and site data for Buzzfeed.com is remained in brave://settings/siteData and brave://settings/content/all

7. Clear cookies and site data when you quit Brave
Scenarios 1:

1. Open couple of sites and stored cookies
2. Navigate to brave://settings/cookies and enable Clear cookies and site data when you quit Brave radio button
3. Visit brave://settings/siteData and ensure that cookies are stored
4. Disable social media settings in brave://settings/socialBlocking
5. Close all the tabs in which sites are opened
6. Restart the browser

---- >Verified that all cookies and site data is removed from brave://settings/siteData

Scenarios 2:

1. Open couple of sites and stored cookies
2. Navigate to brave://settings/cookies and enable Clear cookies and site data when you quit Brave radio button
3. Visit brave://settings/siteData and ensure that cookies are stored
4. Ensure social media settings are enabled in brave://settings/socialBlocking
5. Close all the tabs in which sites are opened
6. Restart the browser

----> Verified that 1 cookies (for google.com ) is still present in the brave://settings/siteData which is expected as social media blocking settings for google login 3rd party sites is enabled.

Scenario 3:

1. Browse brave for 3 days and store 3 days cookies
2. Set Time range to 24 hours in brave://settings/clearBrowserData
3. On the 3rd day, navigate to brave://settings/cookies and enable Clear cookies and site data when you quit Brave radio button
4. Visit brave://settings/siteData and ensure that cookies are stored
5. Close all the tabs in which sites are opened
6. Restart the browser

---->Verified that cookies are deleted only from last 24 hours and the cookies which are stored on 1st and 2nd days are still available in brave://settings/siteData

2. Brave://settings/security verifications

• Verified that Security settings in brave://settings/security

• Select No protection (not recommended) option from Safe browsing and ensured that the alert message is shown with brave branded buttons cancel and Turn off
  
• Select Turn off button and ensured that No protection (not recommended) is selected in brave://settings/security
  

3. Safety check verifications

• Verified that Safety check is available under brave://settings/privacy settings

• Click on Check now and ensured that all the options which are available under Safety check are updated correctly
  

• Ensured that Relaunch option is shown for Updates if there are any latest brave versions available
  

• Ensured that relaunch browser updates the brave version to latest version and safety check for Updates is up to date
  

• Verified that the correct message is shown for Safe browsing when safe browsing is OFF in brave://settings/security
  

• Verified that click on Manage redirects to safe browsing security page as expected
  

• Installed harmful extensions in brave and verified that the correct message is shown for extensions under safety check
  

[btlechowski]

Verification passed on Brave v1.16.20 on Samsung s7 (Android 8.0).

Most of the testing was done in #11730

[kjozwiak]

Labeling this one as QA/No in favour of #11747.