Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add support for #enable-force-dark #11085

Closed
anthonypkeane opened this issue Aug 4, 2020 · 3 comments · Fixed by brave/brave-core#6514
Closed

[Android] Add support for #enable-force-dark #11085

anthonypkeane opened this issue Aug 4, 2020 · 3 comments · Fixed by brave/brave-core#6514

Comments

@anthonypkeane
Copy link

Description

See: https://bravesoftware.slack.com/archives/C0816QH3R/p1596571834338300

Enable support for #enable-force-dark

Add a setting in Settings > Display > Appearance
As the top menu item add

Enable "Night Mode"

Exact label text TBD

@anthonypkeane anthonypkeane added QA/Yes OS/Android Fixes related to Android browser functionality labels Aug 4, 2020
@anthonypkeane anthonypkeane added this to New Issues in Android Core 1.14 Aug 4, 2020
@anthonypkeane anthonypkeane removed this from New Issues in Android Core 1.14 Aug 4, 2020
@anthonypkeane anthonypkeane added this to New Issues in Android Core 1.13 Aug 4, 2020
@srirambv
Copy link
Contributor

srirambv commented Aug 5, 2020

Enable "Night Mode" should be Enable "Night Mode" (Experimental)

@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2020

Verification passed on OnePlus 6T with Android 10 running 1.15.54 x64 beta build

  • Verified new settings option Enable "Night Mode"(Experimental) is listed under Settings -> Appearance
  • Verified enabling/disabling the settings prompts for a relaunch
  • Veriifed selecting later in relaunch prompt doesn't cause the webview to either go dark or remain white until browser is restarted
  • Verified enabling the settings enables the flag chrome://flags#enable-force-dark
  • Verified enabling the settings causes webview to be dark mode
Setting Restart alert Flag Dark webview
image image image image

Logged followup issue for missing translation #11781


Tablet test blocked on #11783

Verification passed on Samsung Tab A with Android 10 running 1.15.54 x64 beta build

  • Verified new settings option Enable "Night Mode"(Experimental) is listed under Settings -> Appearance
  • Verified enabling/disabling the settings prompts for a relaunch
  • Verified selecting later in relaunch prompt doesn't cause the webview to either go dark or remain white until the browser is restarted
  • Verified enabling the settings enables the flag chrome://flags#enable-force-dark
  • Verified enabling the settings causes webview to be dark mode
Setting Restart alert Flag Dark webview
image image image image

@Dev-i-l
Copy link

Dev-i-l commented Sep 26, 2020

PLEASE MAKE SURE THAT DARK MODE IS ACCESSIBLE THROUGH 3-DOT MENU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

4 participants