Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling night mode doesn't trigger browser restart prompt #11783

Closed
srirambv opened this issue Sep 21, 2020 · 1 comment · Fixed by brave/brave-core#6719
Closed

Enabling night mode doesn't trigger browser restart prompt #11783

srirambv opened this issue Sep 21, 2020 · 1 comment · Fixed by brave/brave-core#6719
Assignees
Labels
android-tablet-specific feature/settings OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android Tab QA/Yes release/blocking release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Enabling night mode doesn't trigger browser restart prompt

Steps to reproduce

  1. Install 1.15.54 x64 beta build via GPS/Side load
  2. Go to Settings -> Appearance -> Toggle Enable "Night mode"(Experimental"
  3. No browser restart prompt is shown
  4. Manually restart the browser, still no dark mode on webview
  5. Open chrome://flags, Force dark mode flag is not enabled

Actual result

https://youtu.be/bCaVXPnDfn0

Expected result

Should

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Tab A
  • Android version: 10

Brave version

1.15.54 beta build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv
Copy link
Contributor Author

srirambv commented Oct 1, 2020

Verification passed on Samsung Tab A with Android 10 running 1.15.69 x64 build

  • Verified enabling night mode triggers browser restart prompt
  • Verified night mode is only enabled after browser restart
  • Verified enabling night mode enables the flag as well under brave://flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-tablet-specific feature/settings OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android Tab QA/Yes release/blocking release-notes/exclude
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

2 participants