Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Allowed Cookies Can Not Be Deleted #11259

Closed
hennrynusasatria opened this issue Aug 17, 2020 · 20 comments
Closed

The Allowed Cookies Can Not Be Deleted #11259

hennrynusasatria opened this issue Aug 17, 2020 · 20 comments
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@hennrynusasatria
Copy link

Hi All,

Description:
The allowed cookies can not be deleted, please check the following screenshot:

image

Steps to Reproduce:

  1. Open brave://settings/content/cookies
  2. Delete the allowed cookies
  3. The allowed cookies can not be deleted

Actual result:
The allowed cookies can not be deleted

Expected result:
The allowed cookies must be able to be deleted

Reproduces how often:
Easily reproduced

Desktop Brave version:
Version 1.12.112 Chromium: 84.0.4147.125 (Official Build) (32-bit)

Android Device details:

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: Android 9
@hennrynusasatria hennrynusasatria added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 17, 2020
@dentistformyeye
Copy link

#8604 is the same as this issue, except the former only mentions desktop.

@hennrynusasatria
Copy link
Author

Hi @dentistformyeye

Yes, #8604 and #10532 are the same as this issue, this also happens on Brave Android

cc: @rebron @tomlowenthal

@bsclifton
Copy link
Member

+1 from @cjwijtmans via #11515 for deleting embedded cookies

Steps to Reproduce

  1. go to brave://settings/content/cookies
  2. see "embedded" cookies with trash icon
  3. click trash icon

Actual result:

nothing happens, cookie setting is still there

Expected result:

cookie setting is deleted

@diracdeltas diracdeltas added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 31, 2020
@invictivi
Copy link

Hi Guys, is there a known workaround for this issue?
Is going directly to the particular website then Lock >> Cookies >> Block does the trick (even if that website still appears on my list Sites that can always use cookies)?

@snowbound
Copy link

See #12375

@Saxonis
Copy link

Saxonis commented Jan 14, 2021

Same issue here with Windows 7 64bit.

@snowbound
Copy link

I wonder if this is at all related to another festering issue with Brave in that it does not seem to be able to delete certain Google based cookies upon browser closure #9085

@User198263321
Copy link

The way it works on mobile is that you can block cookies that were previously allowed but when you delete blocked cookies, it moves it back to "allowed" and when you try to remove them from allowed, it does nothing.

@Brave-Matt
Copy link

@snowbound
Copy link

snowbound commented Jun 15, 2021

I am trying out Vivaldi which like Chrome and MS Edge Chromium has no issues deleting the .google.com cookie when one exits the browser in question. This was in reference to a 14+ month old issue #9085 I struggle with Brave in that it leaves you logged into ALL of your Google accounts unless you a) remember to use Google's logout pulldown or b) do the scorch earth approach and delete ALL cookies every time you close the browser.

@cjwijtmans
Copy link

Ms edge is actually the best chromium browser i ever used. It probably does a ton of spyware stuff but oh well.. i just avoid using edge for anything i consider too personal. But a ms browser that is actually and vscode which is the best ide ever. Looks like microsoft actually makes good software now. What world am i living today 🤦🏼‍♂️. Anyhow brave leaves a sour taste when it comes to usability.

@snowbound
Copy link

I must say that Brave has been the most frustrating browser to report issues regarding. Thankfully the devs here still respond to threads. I had high hopes for Brave when I started using it for the first time back in 2019. It was a breath of fresh air wrt support. I have been very vocal wrt Brave and support issues in Brave Community and Reddit which becomes full of BAT-related issues.

@joloyonaha
Copy link

Having an issue removing/hiding these 2?
cookie

Turn off the 'Google login buttons...' and the above cookies will be hidden.
toggle

Let me know if this works for you.

@cjwijtmans
Copy link

I never turned on that option in the first place. And i believe "hiding" cookies is a terrible idea.

@snowbound
Copy link

Ditto for me. I made sure that Google Login buttons was disabled. I have had to resort using a third party extensionCookie AutoDelete to fix this issue as outline in #9085

@bridiver
Copy link
Contributor

bridiver commented Feb 4, 2022

I never turned on that option in the first place. And i believe "hiding" cookies is a terrible idea.

The option currently is on by default as a compromise for user experience. The default settings block the use of google login for sites and most users would be unable to fix that without allowing much more than necessary. This may be removed soon after we verify everything still works correctly with partitioned cookie storage cc @pes10k

@bridiver
Copy link
Contributor

bridiver commented Feb 4, 2022

this has been mentioned in other related issues, but currently cookie settings created by shields are not deletable in the brave://settings/content/cookies UI, they can only be changed in the shields panel. The reasons are a bit complicated, but the gist is that these cookie settings are auto-generated by combining brave specific cookie settings and shields on/off settings. They show up here because the final result is a chromium cookie setting, but it's not a setting that is currently persisted along with the ones you create on this page yourself (which are deletable). Also until somewhat recently it wasn't possible to express "block third party cookies on b.com" in a single content setting so in some cases you'd end up with two settings in brave://settings/content/cookies that actually corresponded to a single setting in brave shields and deleting only one of them would be problematic. Now that it is possible to have a single setting for block third party, we are looking at making changes that will make it possible to add/delete cookie settings in either the shields panel or the brave://settings/content/cookies

@User198263321
Copy link

this has been mentioned in other related issues, but currently cookie settings created by shields are not deletable in the brave://settings/content/cookies UI, they can only be changed in the shields panel. The reasons are a bit complicated, but the gist is that these cookie settings are auto-generated by combining brave specific cookie settings and shields on/off settings. They show up here because the final result is a chromium cookie setting, but it's not a setting that is currently persisted along with the ones you create on this page yourself (which are deletable). Also until somewhat recently it wasn't possible to express "block third party cookies on b.com" in a single content setting so in some cases you'd end up with two settings in brave://settings/content/cookies that actually corresponded to a single setting in brave shields and deleting only one of them would be problematic. Now that it is possible to have a single setting for block third party, we are looking at making changes that will make it possible to add/delete cookie settings in either the shields panel or the brave://settings/content/cookies

So you are saying that normally if we make changes via brave shields, the cookies on those sites are permanent unless you undo those changes? That what it looked like to me when I was having this issue.

@bridiver
Copy link
Contributor

bridiver commented Feb 4, 2022

So you are saying that normally if we make changes via brave shields, the cookies on those sites are permanent unless you undo those changes? That what it looked like to me when I was having this issue.

I'm not sure what you mean by "the cookies on those sites are permanent". All I'm saying is that cookie settings made in brave shields can currently only be managed through brave shields. Deleting these settings does not delete any existing cookies no matter how or where they were created, that is controlled under brave://settings/siteData. If you are trying to delete actual cookies, you're in the wrong settings page.

@iefremov
Copy link
Contributor

duplicate of #12375

@iefremov iefremov added the closed/duplicate Issue has already been reported label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests