Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Implement Widgets on Android #11658

Closed
anthonypkeane opened this issue Sep 10, 2020 · 1 comment · Fixed by brave/brave-core#6779
Closed

[Android] Implement Widgets on Android #11658

anthonypkeane opened this issue Sep 10, 2020 · 1 comment · Fixed by brave/brave-core#6779
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@anthonypkeane
Copy link

Description

Please implement Widgets on Android.

Details can be found in the "Mobile Widgets" doc on G-Drive

@anthonypkeane anthonypkeane added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes OS/Android Fixes related to Android browser functionality labels Sep 10, 2020
@anthonypkeane anthonypkeane added this to Backlog in Android General via automation Sep 10, 2020
@anthonypkeane anthonypkeane moved this from Backlog to P3/P4/P5 in Android General Sep 10, 2020
@deeppandya deeppandya added this to the 1.17.x - Nightly milestone Oct 17, 2020
Android General automation moved this from P3/P4/P5 to Done/Closed Oct 17, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.17.71 x64 RC build

  • Verified on a clean install NTP shows widgets
  • Verified default widget is privacy stats
  • Verified Privacy Stats/Favourites/Binance is the order of widget stack
  • Verified able to scroll up or down on the widget stack
  • Verified widget can be added/removed by selecting Remove widget via widget menu
  • Verified widget can be added/removed by selecting Edit Stack via widget menu
  • Verified tapping on Edit Stack opens up settings for widget stack
  • Verified left/right swipe on widget stack settings removes the specific widget
  • Verified clicking on the + button next to the widget adds it at the bottom of the widget stack
  • Verified widget order can be changed by moving the entry within the widget stack
  • Verified removing all widgets in the stack doesn't leave a widget container window
  • Verified when the device is set to non-EN locale, widget text doesn't overflow or gets cut off.
  • Verified changing device orientation doesn't stretch widgets. Changing orientation sets the widget to the top right corner of NTP
  • Verified on landscape mode, the widget doesn't overlap on the NTP SI links
  • Verified stats are retained on upgrade from 1.16.x and tapping on privacy stats brings up the bottom sheet report
  • Verified clicking on favourites from upgrade loads the site correctly
  • Verified able to delete top sites from the widget on both clean install and upgrade
  • Verified changing bottom toolbar behaviour doesn't mess up with the widget location

Verification passed on Samsung Tab A with Android 10 running 1.17.71 x64 RC build

  • Verified on a clean install NTP shows widgets
  • Verified default widget is privacy stats
  • Verified Privacy Stats/Favourites/Binance is the order of widget stack
  • Verified able to scroll up or down on the widget stack
  • Verified widget can be added/removed by selecting Remove widget via widget menu
  • Verified widget can be added/removed by selecting Edit Stack via widget menu
  • Verified tapping on Edit Stack opens up settings for widget stack
  • Verified left/right swipe on widget stack settings removes the specific widget
  • Verified clicking on the + button next to the widget adds it at the bottom of the widget stack
  • Verified widget order can be changed by moving the entry within the widget stack
  • Verified removing all widgets in the stack doesn't leave a widget container window
  • Verified when the device is set to non-EN locale, widget text doesn't overflow or gets cut off.
  • Verified changing device orientation doesn't stretch widgets. Changing orientation sets the widget to the top right corner of NTP
  • Verified on landscape mode, the widget doesn't overlap on the NTP SI links
  • Verified stats are retained on upgrade from 1.16.x and tapping on privacy stats brings up the bottom sheet report
  • Verified clicking on favourites from upgrade loads the site correctly
  • Verified able to delete top sites from the widget on both clean install and upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

3 participants