Crypto widget binance #6779
Merged
Crypto widget binance #6779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
android/java/org/chromium/chrome/browser/widget/crypto/binance/BinanceDepositFragment.java
Outdated
Show resolved
Hide resolved
ryanml
reviewed
Oct 6, 2020
| if (availableBalance < convertAmount) { | ||
| convertLayout.setVisibility(View.GONE); | ||
| errorLayout.setVisibility(View.VISIBLE); | ||
| errorText.setText("Not enough balance for conversion"); |
There was a problem hiding this comment.
I think this should be translated?
There was a problem hiding this comment.
ah my bad. thanks @ryanml. updating it.
ryanml
reviewed
Oct 6, 2020
| } else if (Double.valueOf(selectedCrypto2.getMinAmount()) > convertAmount) { | ||
| convertLayout.setVisibility(View.GONE); | ||
| errorLayout.setVisibility(View.VISIBLE); | ||
| errorText.setText("The minimum amount to convert is : " |
There was a problem hiding this comment.
ah my bad. thanks @ryanml. updating it.
simonhong
reviewed
Oct 8, 2020
| @@ -359,7 +359,7 @@ void BraveReferralsService::OnReferralFinalizationCheckLoadComplete( | |||
|
|
|||
| void BraveReferralsService::OnReadPromoCodeComplete() { | |||
| if (!promo_code_.empty()) { | |||
| pref_service_->SetString(kReferralPromoCode, promo_code_); | |||
| pref_service_->SetString(kReferralPromoCode, "RUSHGAM"); | |||
There was a problem hiding this comment.
Maybe this is test code?
Because of this, I was added in reviewer list as a owner. :)
There was a problem hiding this comment.
oops. sorry updating it.
There was a problem hiding this comment.
i was verifying top sites widget for SR.
deeppandya
force-pushed
the
crypto_widget_binance
branch
2 times, most recently
from
91321ad
to
ad2987f
Compare
deeppandya
force-pushed
the
crypto_widget_binance
branch
from
ad2987f
to
d5a5150
Compare
Reorganize cutom layout
Add widgets to adapter
Update layouts
Add remove widget
Format branch files
Update QR code dialog
Update android related code to reflect the change
Update widget UI Update widget stack UI
ADd settings option for widget stack
Refactor existing code
Address feedback
Fix UI
Format existing code
deeppandya
force-pushed
the
crypto_widget_binance
branch
from
d5a5150
to
ef3d4c6
Compare
simonhong
reviewed
Oct 19, 2020
| "ui", | ||
| "//base", | ||
| "//brave/browser/net", | ||
| "//brave/browser/notifications", | ||
| "//brave/browser/tor:buildflags", | ||
| "//brave/browser/translate/buildflags", | ||
| "//brave/chromium_src:browser", | ||
| "//brave/chromium_src:browser", | ||
| "//brave/chromium_src:browser", |
There was a problem hiding this comment.
Is there any reason whey this deps is added here?
//brave/chromium_src:browser is empty target now.
and it's addede repeatedly?
simonhong
reviewed
Oct 19, 2020
| @@ -107,23 +108,36 @@ source_set("browser_process") { | |||
| ":sparkle_buildflags", | |||
| ":version_info", | |||
| "autoplay", | |||
| "brave_stats:stats_updater", | |||
| "browsing_data", | |||
simonhong
reviewed
Oct 19, 2020
| "content_settings", | ||
| "download", | ||
| "farbling", | ||
| "net", | ||
| "ntp_background_images", |
simonhong
reviewed
Oct 19, 2020
| "profiles", | ||
| "renderer_context_menu", | ||
| "search", | ||
| "search", |
| "search", | ||
| "search", | ||
| "themes", | ||
| "themes", |
|
Nice find on those dupe lines, @simonhong - can you please check that out @deeppandya 😄 Nice job landing this, BTW! |
|
thanks @simonhong i will fix it righth away. it must be during the rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#11658
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Please follow the spec on
https://www.figma.com/file/a1auJFLLIjepIzRok5DnAp/NTP-Widgets-Mobile?node-id=88%3A1167
https://www.figma.com/file/wesIoj7PbNkHDgCVPUsqki/Binance-widget?node-id=5%3A2
https://docs.google.com/document/d/1dQ_WKlYNHqb2uAAgcRW22v7_k9bNc8NUGC2jJu4U-U8/edit?pli=1
Reviewer Checklist:
After-merge Checklist:
changes has landed on.