Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Passwords" entry in the "Safety check" section of the Settings UI. #11741

Closed
mkarolin opened this issue Sep 16, 2020 · 3 comments · Fixed by brave/brave-core#6657
Closed

Comments

@mkarolin
Copy link
Contributor

Description

Starting with Chromium 86, there is a "Safety Check" section in the Settings UI. One of the items in the section is "Passwords" which, to work, requires a connected user account. Because Brave doesn't have a connected user account the item needs to be hidden.

Steps to Reproduce

  1. Open Brave
  2. Navigate to brave://settings/safetyCheck
  3. Click "Check now"
  4. See items in the results (one of them is "Passwords").

Expected result:

"Passwords" item is not shown.

Reproduces how often:

100%

Brave version (brave://version info)

1.16.20 (Nightly).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 24, 2020

Verification passed on

Brave | 1.15.60 Chromium: 86.0.4240.42 (Official Build) dev (64-bit)
-- | --
Revision | 418ccfc2b69112bd79d5ffb38b533642e64e6af8-refs/branch-heads/4240@{#773}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • Verified the STR from the description
    image

Verification passed on

Brave 1.15.60 Chromium: 86.0.4240.42 (Official Build) dev (64-bit)
Revision 418ccfc2b69112bd79d5ffb38b533642e64e6af8-refs/branch-heads/4240@{#773}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description

image


Verification passed with

Brave 1.15.63 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS macOS Version 10.14.6 (Build 18G3020)

Verified STR from description
Also ran the Safety Check while running FiddlerEverywhere. Confirmed no calls to Google were observed on a clean profile.

Screen Shot 2020-09-25 at 9 30 22 AM

@fmarier
Copy link
Member

fmarier commented Oct 5, 2020

There's another piece of this at the bottom of brave://setttings:
Screenshot from 2020-10-05 14-00-28
which needs to be modified because we don't currently offer any data breach notifications (though we want to in #12001).

I'd suggest the following:

Brave can help keep you safe from malicious websites, bad extensions and more

@srirambv
Copy link
Contributor

srirambv commented Oct 6, 2020

@fmarier logged #12008 as suggestion. Since the issue is already fixed and verified should not be reopening the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment